select option value and assigning value to var (javascript)

Question

Edit: I've changed the code as follows. Now none of the code seems to work. (Even my the code that did work and I didn't share with you.)

function berekeningAflostabel() {
var zaaksoortMsnp;
var AflostabelPerMaand;

document.getElementById("fldZaakSoortMsnp").addEventListener("change",     function () {
  AflostabelPerMaand = this.value;

  if(AflostabelPerMaand == 1) {
    zaaksoortMsnp = "Tekst1";
  }
  if(AflostabelPerMaand == 2) {
    zaaksoortMsnp = "Tekst2";
  }
  if(AflostabelPerMaand == 3) {
    zaaksoortMsnp = "Tekst3";
  }
  if(AflostabelPerMaand == 4) {
    zaaksoortMsnp = "Tekst4";
  }
  if(AflostabelPerMaand == 5) {
    zaaksoortMsnp = "Tekst5";
  }
  if(AflostabelPerMaand == 6) {
    zaaksoortMsnp = "Tekst6";
  }

  document.getElementById("fldMinimaleAfloswaardePerMaand").value = zaaksoortMsnp;
  }
}

var eventZaaksoortMsnp = document.getElementById("fldZaakSoortMsnp");
eventZaaksoortMsnp.addEventListener("change", berekeningAflostabel);

As an optimisation just set the value to be 0x (x is the number) or at least remove all the ifs and do this: var AflostabelPerMaand = '0' + zaaksoortMsnp.value;! — ibrahim mahrir
– ibrahim mahrir, Commented Mar 1, 2017 at 11:30
The 01, 02 etc. values for AflostabelPerMaand is a dummy text. If it works, I'll replace them with currency values. — NielsSanders
– NielsSanders, Commented Mar 1, 2017 at 11:33

Peter Kota · Accepted Answer · 2017-03-02 07:40:31Z

1

If you would like to get the selected option's value inside the change listener then you should use: this.options[this.selectedIndex].value

You need to apply the change listener only once. The last two line are unnecessary.

The following code should work:

function berekeningAflostabel() {
  var zaaksoortMsnp;
  var AflostabelPerMaand;

  document.getElementById("fldZaakSoortMsnp").addEventListener("change", function() {
    AflostabelPerMaand = this.options[this.selectedIndex].value;

    if(AflostabelPerMaand == 1) {
      zaaksoortMsnp = "Tekst1";
    }
    if(AflostabelPerMaand == 2) {
      zaaksoortMsnp = "Tekst2";
    }
    if(AflostabelPerMaand == 3) {
      zaaksoortMsnp = "Tekst3";
    }

    document.getElementById("fldMinimaleAfloswaardePerMaand").value = zaaksoortMsnp;
  });
}

berekeningAflostabel();

<select id="fldZaakSoortMsnp">
  <option value="1">teszt</option>
  <option value="2">teszt</option>
  <option value="3">teszt</option>
</select>

<input type="text" id="fldMinimaleAfloswaardePerMaand">

edited Mar 2, 2017 at 7:40

answered Mar 1, 2017 at 11:28

Peter Kota

8,3905 gold badges29 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ibrahim mahrir Over a year ago

The ifs are unnecessary in the first place!

ibrahim mahrir Over a year ago

It's seems that OP is looking for this answer not mine!

ibrahim mahrir Over a year ago

But you should use == not === as they're not of the same type (one is a string , the other is a number)!

NielsSanders Over a year ago

I've edited my original message. (Couldn't add another message with new code.) If you'd like to react, that'll be awesome. Thanks!

Ararat Harutyunyan · Accepted Answer · 2017-03-01 11:39:47Z

1

change your function to this

function () {
    var AflostabelPerMaand = '0' + this.value;
    document.getElementById("fldMinimaleAfloswaardePerMaand").value = AflostabelPerMaand;
}

edited Mar 1, 2017 at 11:39

answered Mar 1, 2017 at 11:38

Ararat Harutyunyan

9362 gold badges8 silver badges19 bronze badges

1 Comment

Peter Kota Over a year ago

"The 01, 02 etc. values for AflostabelPerMaand is a dummy text."

Collectives™ on Stack Overflow

select option value and assigning value to var (javascript)

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related