Rails 3 Including Nested Module Inside Controller

Question

I have a controller that I'd like to include some standard methods.

class Main::UsersController < Main::BaseController
  include MyModule::ControllerMethods
end

uninitialized constanct MyModule::ClassMethods::InstanceMethods

My module looks like this, which is also wrong, and was originally meant for a model. What's the best way to do it so that I can use it with a controller as well?

module MyModule
  def self.included(base)
    base.has_one  :example, :autosave => true
    base.before_create :make_awesome        

    base.extend ClassMethods
  end

  module ClassMethods
    ...
    include InstanceMethods
  end

  module InstanceMethods
     ...
  end

  module ControllerMethods
    ...
    # I want to include these in my controller
    def hello; end
    def world; end
  end

end

Petrik de Heus · Accepted Answer · 2010-11-24 08:22:56Z

4

Use extend instead of include for your ClassMethods. You should also split your model and controller modules:

module MyModule    
  module ModelMethods
    def acts_as_something
      send :has_one,  :example, :autosave => true
      send :before_create, :make_awesome  
      send :include, InstanceMethods
    end
    module InstanceMethods
      ...
    end


  end

  module ControllerMethods
    ...
    # I want to include these in my controller
    def hello; end
    def world; end
  end

end

ActiveRecord::Base.extend MyModule::ModelMethods

Your Model would then look like this:

class Model < ActiveRecord::Base
  acts_as_something
end

edited Nov 24, 2010 at 8:22

answered Nov 23, 2010 at 11:58

Petrik de Heus

9706 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jamison Dance Over a year ago

This article by Yehuda Katz goes in to more detail about why just using extend is better than overriding include to extend: yehudakatz.com/2009/11/12/better-ruby-idioms

Dex Over a year ago

Just curious, you put Base.extend MyModule::ModelMethods, but what does Base pertain to. Should it be ActiveRecord::Base?

Petrik de Heus Over a year ago

I thought I would keep it simple by using Base, but it's probably more confusing. I've changed the answer to use ActiveRecord::Base

Collectives™ on Stack Overflow

Rails 3 Including Nested Module Inside Controller

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related