I want to save an array of string with mongoose, but i am getting errors

Question

I want to save an array of strings, but I am getting the following error:

Error: Can't set headers after they are sent.

this is my code to save:

router.post('/addalluserskills', function(req, res){
    console.log(req.body);
        var userSkill = new UserSkill();
        userSkill.email = req.session.email;

    for (var i = 0; i < req.body.mySkills; i++){

        userSkill.user_skill_id = req.body.mySkills[i];
        userSkill.save(function(err){
        if(err) return res.send(err);
        res.json({
            message: '201: Successfully added skill'
        });
    });
    }

});

Can't I do a save twice? I don't understand what could be the problem here. Is the connection still open and I need to close before sending another one?

Edited:

Answer:

router.post('/addalluserskills', function(req, res){

    for (var i = 0; i < req.body.mySkills.length; i++){
        var userSkill = new UserSkill();
        userSkill.email = req.session.email;
        userSkill.user_skill_id = req.body.mySkills[i];
        userSkill.save(function(err){
        if(err) return res.send(err);

    });
    }
            res.json({
                message: '201: Successfully added skill'
            });

});

parwatcodes · Accepted Answer · 2017-03-03 05:34:26Z

1

send the response after the whole array process is done,

previously your req.body.mySkills contains the array, you process the first element from array and save it and do res.json and again the the 2nd element from the array is processed and you are send the response header res.json again, which will throw an error Error: Can't set headers after they are sent. because you already had send the response headers.

router.post('/addalluserskills', function (req, res) {
    console.log(req.body);
    var userSkill = new UserSkill();
    userSkill.email = req.session.email;

    for (var i = 0; i < req.body.mySkills; i++) {
        userSkill.user_skill_id = req.body.mySkills[i];
        userSkill.save(function (err) {
            if (err) return res.send(err);
        });
    }
    res.json({
        message: '201: Successfully added skill'
    });

});

edited Mar 3, 2017 at 5:34

answered Mar 3, 2017 at 5:25

parwatcodes

6,8045 gold badges29 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user3450754 Over a year ago

I've added the complete correct answer to my initial question. But I will upvote your answer, because it helped.

parwatcodes Over a year ago

mine solution was for Error: Can't set headers after they are sent, and I provided you that. It's up to you later how you handle the code, modify it. It's the solution and you have to accept it

parwatcodes Over a year ago

and you shouldn't do var userSkill = new UserSkill(); inside the for loop, you will creating same instances multiple times... reapeating same work

Collectives™ on Stack Overflow

I want to save an array of string with mongoose, but i am getting errors

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related