BCrypt hash error

Question

this is my code for hashing password and for compare existing password into existing module with a password that has been sended on body request:

        //hash password of document that use this schema
    bcrypt.hash(user.password, null, null, function (err, hashed) {

        if (err) {
            throw err;
        } else {
            user.password = hashed;

            //next api
            next();
        }
    })
});

userSchema.methods.comparePassword = function (password) {

    //refer at userSchema
    var user = this;

    //return method of bcryot library that compare two string: original password and password hashed
    return bcrypt.compareSync(password, user.password);

};

But compare this error message:

Uncaught, unspecified "error" event. (Not a valid BCrypt hash.)

Morris · Accepted Answer · 2017-03-04 10:41:55Z

2

Resolved !!! Into the database i have a lot of user's password not hashed and when i try to login, with bcrypt.compareSync (password, user.password); it expected that has been hashed password.

answered Mar 4, 2017 at 10:41

Morris

6011 gold badge8 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

William Carron · Accepted Answer · 2017-03-03 22:03:21Z

1

You're using null twice. I'd wager that you've wrapped this function inside the bcrypt.genSalt function(if you haven't , do so). You need to pass it the bcrypt salt where the first null is written.

Here's a full example:

userSchema.pre('save', function (next) {
  const SALTROUNDS = 10;  // or another integer in that ballpark
  const user = this;
  if(!user.isModified('password')) {
    return next();
  }

  bcrypt.genSalt(SALTROUNDS, (err, salt) => {
    if (err) { return next(err); }

    bcrypt.hash(user.password, salt, null, (error, hash) => {
      if (error) { return next(error); }

      user.password = hash;
      next();
    });
  });
});

answered Mar 3, 2017 at 22:03

William Carron

4207 silver badges18 bronze badges

Collectives™ on Stack Overflow

BCrypt hash error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related