What went wrong led to prevent use LIMIT function on MySQL query using php?

Question

i have this query

public function getGameHomes_limit($page,$limit){
    $query = sprintf('SELECT %1$sserver_homes.*,%1$sremote_servers.*, %1$sconfig_homes.*
        FROM `%1$sserver_homes` NATURAL JOIN `%1$sconfig_homes` NATURAL JOIN `%1$sremote_servers`; ',
        $this->table_prefix);
    return $this->listQuery($query);
}

and i need to set LIMIT

public function getGameHomes_limit($page,$limit){
    $query = sprintf('SELECT %1$sserver_homes.*,%1$sremote_servers.*, %1$sconfig_homes.*
        FROM `%1$sserver_homes` LIMIT '.$page.','.$limit.' NATURAL JOIN `%1$sconfig_homes` NATURAL JOIN `%1$sremote_servers`; ',
        $this->table_prefix);
    return $this->listQuery($query);
}

but i have this error

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'NATURAL JOIN ogp_config_homes NATURAL JOIN ogp_remote_servers' at line 2

bobby-tables.com Don't build SQL queries by string concatenation or variable substitution. Your code is wide open to SQL injection attacks. — GordonM
– GordonM, Commented Mar 14, 2017 at 21:24
please can you explain in example how can i protect my code from injection ? — Obada Diab
– Obada Diab, Commented Mar 14, 2017 at 21:28
Learn about prepared statements for MySQLi. Even escaping the string is not safe! Don't believe it? — Jay Blanchard
– Jay Blanchard, Commented Mar 14, 2017 at 21:33

Morgs · Accepted Answer · 2017-03-14 21:16:57Z

2

Change the order of your query and make LIMIT the last bit like so:

public function getGameHomes_limit($page,$limit){
    $query = sprintf('SELECT %1$sserver_homes.*,%1$sremote_servers.*, %1$sconfig_homes.*
        FROM `%1$sserver_homes` NATURAL JOIN `%1$sconfig_homes` NATURAL JOIN `%1$sremote_servers` LIMIT '.$page.','.$limit.'; ',
        $this->table_prefix);
    return $this->listQuery($query);
}

answered Mar 14, 2017 at 21:16

Morgs

1,7663 gold badges23 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Morgs Over a year ago

Great, consider marking it as an answer so the rest don't spend time giving more answers.

Collectives™ on Stack Overflow

What went wrong led to prevent use LIMIT function on MySQL query using php?

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related