Replace each character of string with new character string

Question

The c# program I'm developing checks the first character of user input and if it starts with . (dot) I want to replace each character of user input with pacified character string while the user is writing, but I'm getting the error

Index out of bounds exception

My code:

if (textBox1.Text.StartWith(".")) {
    string MyText = "Hello World";
    int x = 0;
    string NewText;
    while (x <= MyText.Length) {
        NewText = textBox1.Text.Replace(textBox1.Text[x], MyText[x]);
        TextBox1.Text = NewText;
        x++;
    }
}

x<=MyText.Length goes out of bounds. Arrays are 0 indexed. — Philipp
– Philipp, Commented Mar 27, 2017 at 11:17

Chris Pickford · Accepted Answer · 2017-03-27 11:17:30Z

3

You're overrunning the bounds of the string, replace:

while (x <= MyText.Length) {

with

while (x < MyText.Length) {

answered Mar 27, 2017 at 11:17

Chris Pickford

9,0606 gold badges51 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

daniell89 · Accepted Answer · 2017-03-27 11:18:14Z

2

while(x < MyText.Length)

or

while(x <= MyText.Length - 1)

If array has length = x, its last index is x-1, because array starts from 0 index

answered Mar 27, 2017 at 11:18

daniell89

2,34220 silver badges28 bronze badges

1 Comment

Magnus Over a year ago

@Elias You should check textBox1.Text.Length also.

Dmitrii Bychenko · Accepted Answer · 2017-03-27 11:28:13Z

1

If I understand you right (there're no samples in question), I suggest using Linq which is straitforward; try using modular arimethics - index % MyText.Length to avoid index problems

string source = ".My Secret Message for Test";
string MyText = "Hello World";

// If user input starts with dot
if (source.StartsWith("."))
  source = string.Concat(source
    .Select((c, index) => MyText[index % MyText.Length])); 

TextBox1.Text = source;

Outcome:

   Hello WorldHello WorldHello

edited Mar 27, 2017 at 11:28

answered Mar 27, 2017 at 11:22

Dmitrii Bychenko

188k20 gold badges178 silver badges231 bronze badges

Comments

Ivan Chepikov · Accepted Answer · 2017-03-27 11:28:13Z

0

First of all as @Daniell89 said:

use

while(x < MyText.Length)

Secondly: You use x as an index not only for MyText but for textBox1.Text too. So you need to check that it is long enough.

you can do something like this:

while (x < Math.Min(MyText.Length, textBox1.Text.Length)
{
    NewText = textBox1.Text.Replace(textBox1.Text[x], MyText[x]);
    TextBox1.Text = NewText;
    x++;
}

But I think it would be better to use for statement here.

answered Mar 27, 2017 at 11:28

Ivan Chepikov

8255 silver badges23 bronze badges

Collectives™ on Stack Overflow

Replace each character of string with new character string

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related