How to control data stored in an array

Question

Sorry i want to store specific input data/numbers in an array. In my array i want only the correct numbers to be stored and not the wrong once. I want the proram to continue as long as i have not gotten 4 correct number in my array. Then i want to print out the total number of array value. How can I do this in C#? Here is my code:

            int min = 5;
            int max = 10;
            int[] array = new int[4];
            int count = 0;

            for (int i = 0; i < array.Length; i++)
            {
            Console.WriteLine("enter btw 5 och 10");
            int val = int.Parse(Console.ReadLine());
            array[i] = val;

            if (val >= min && val <= max)
            {
                Console.WriteLine("Correct, continue...");
                count++;
                continue;
            }
            else
            {
                Console.WriteLine("wrong, enter btw 5 och 10");
                continue;
            }

            }
            Console.WriteLine(count);
            Console.ReadKey();
}

If someone enter e.g 11 or 2, the program will not count it. Thank you for the help.

Why an array? Why not a more-specialized collection type?

rory.ap
– rory.ap

2017-03-27 11:50:25 +00:00
Commented Mar 27, 2017 at 11:50 — rory.ap
– rory.ap, Commented Mar 27, 2017 at 11:50
@rory.ap probably an assignment from school

Jeroen van Langen
– Jeroen van Langen

2017-03-27 11:52:44 +00:00
Commented Mar 27, 2017 at 11:52 — Jeroen van Langen
– Jeroen van Langen, Commented Mar 27, 2017 at 11:52
What's vektor? Maybe it should be array?

Mighty Badaboom
– Mighty Badaboom

2017-03-27 11:54:33 +00:00
Commented Mar 27, 2017 at 11:54 — Mighty Badaboom
– Mighty Badaboom, Commented Mar 27, 2017 at 11:54

Christopher Lake · Accepted Answer · 2017-03-27 12:31:56Z

1

Fungerar det?

{    
    var min = 5;
    var max = 10;
    var array = new int[4];
    var count = 0;
    var total = 0;

    for (int i = 0; i < array.Length; i++)
    {
        Console.WriteLine("Enter between 5 and 10:");
        var correct = false;

        while (!correct)
        {
            var val = int.Parse(Console.ReadLine());

            if (val >= min && val <= max)
            {
                Console.WriteLine("Right number...");
                array[i] = val; //Add the value to the array
                count++; //Increase count
                total += val; //Add the value to total
                correct = true; //Break the while loop
            }
            else
            {
                Console.WriteLine("Wrong, enter between 5 and 10:");
            }
        }
    }
    Console.WriteLine($"The total of the values are: {total}");
    Console.ReadKey();
}

edited Mar 27, 2017 at 12:31

answered Mar 27, 2017 at 12:10

Christopher Lake

3784 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jeroen van Langen · Accepted Answer · 2017-03-27 12:05:57Z

1

You could try something like:

int min = 5;
int max = 10;
int[] array = new int[4];
int index = 0;

while(true)
{
    Console.WriteLine("enter btw 5 och 10");
    int val = int.Parse(Console.ReadLine());

    if (val >= min && val <= max)
    {
        Console.WriteLine("Rätt siffra...");
        array[index] = val;

        if(index >= array.Length-1)
            break;

        index++;
    }
    else
    {
        Console.WriteLine("wrong, enter btw 5 och 10");
    }
}

Console.WriteLine(index);
Console.ReadKey();

It's even better to use int.TryParse() (like I would write it)

int min = 5;
int max = 10;
int[] array = new int[4];
int count = 0;

while(true)
{
    int val;

    // read the input
    Console.WriteLine("enter btw 5 och 10");
    string input = Console.ReadLine();

    // parse it
    if(!int.TryParse(input, out val))
    {
        Console.WriteLine("Not a valid number");
        continue;
    }

    // check the range
    if (val < min || val > max)
    {
        Console.WriteLine("wrong, enter btw 5 och 10");
        continue;
    }

    // store it.
    Console.WriteLine("Rätt siffra...");
    array[count] = val;

    // are we done?
    if(count== array.Length-1)
        // yes, break the while loop before we increase.
        break;

    // increase array index
    count++;
}

Console.WriteLine(count);
Console.ReadKey();

edited Mar 27, 2017 at 12:05

answered Mar 27, 2017 at 11:55

Jeroen van Langen

22.1k3 gold badges46 silver badges63 bronze badges

2 Comments

Cleptus Over a year ago

Original question could be improved, adding some integer validation, either try-catch or Int32.TryParse()

Addey Over a year ago

Thanks for your comment

Collectives™ on Stack Overflow

How to control data stored in an array

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related