PHP MySQL insert not working

Question

Sorry if it's a quite simple problem. I am not too experienced with web languages.
Basically, it doesn't work.

$insert=
(
  "INSERT INTO phpbb_members ".
  "(emailAddress, uid, valid, firstandlast, propic, memberName) ".
  "VALUES ($me['email'], $uid, 1, $me['name'], $propic, $newuser)"
);
mysql_query($insert) or die('Error, insert query failed');

have you tried just running the query using something like phpmyadmin? That may give you some more insight. Perhaps you have a column name typo or you're missing a column. — Aaron Hathaway
– Aaron Hathaway, Commented Dec 1, 2010 at 17:46

Gazler · Accepted Answer · 2010-12-01 17:47:54Z

5

$insert="INSERT INTO phpbb_members (emailAddress, uid, valid, firstandlast, propic, memberName)
VALUES ('".$me['email']."', $uid, 1, '".$me['name']."', '$propic', $newuser)";

Missing singular quotes (for strings [varchar, char, text, etc]) and you need to close your quotes and concatenate when referencing an array. The above assumed $uid and $newuser are stored numerically in the DB.

answered Dec 1, 2010 at 17:47

Gazler

84.4k18 gold badges285 silver badges245 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ignacio Over a year ago

Exactly, you can't use $me['email'] inside double quotes.

ryryan · Accepted Answer · 2010-12-01 17:47:33Z

3

I think the problem may be in the way you've laid out the information to be inserted.

This should work:

$insert=("INSERT INTO phpbb_members (emailAddress, uid, valid, firstandlast, propic, memberName)
VALUES ('$me[email]', '$uid', '1', '$me[name]', '$propic', '$newuser')");
        mysql_query($insert) or die('Error, insert query failed');

Hope it helps!

EDIT: I'm pretty sure the information to be inserted has to be inside ' '.

answered Dec 1, 2010 at 17:47

ryryan

3,91813 gold badges46 silver badges72 bronze badges

1 Comment

PlyPencil Over a year ago

Thanks this fixed the problem, I hate PHP and all its ' :(

Brian H · Accepted Answer · 2010-12-01 17:44:46Z

3

If you'll use the following for testing, it will show you the error:

mysql_query($insert) or die(mysql_error()."<br />".$insert);

answered Dec 1, 2010 at 17:44

Brian H

8331 gold badge5 silver badges12 bronze badges

Comments

zod · Accepted Answer · 2010-12-01 17:49:03Z

2

$insert=("INSERT INTO phpbb_members (emailAddress, uid, valid, firstandlast, propic, memberName) 
VALUES ($me['email'], $uid, 1, $me['name'], $propic, $newuser)");

Do wee need those extra brackets in the beginning and end? Try to remove it and execute.

$sql = "SELECT * FROM Person";
mysql_query($sql,$con);

answered Dec 1, 2010 at 17:49

zod

12.5k25 gold badges74 silver badges107 bronze badges

Comments

Pradeep Singh · Accepted Answer · 2010-12-01 17:51:19Z

2

$insert=("INSERT INTO phpbb_members (emailAddress, uid, valid, firstandlast, propic, memberName)
VALUES ('".$me['email']."','". $uid."',1,'". $me['name']."','" .$propic."','". $newuser."')");
mysql_query($insert) or die('Error, insert query failed');

answered Dec 1, 2010 at 17:51

Pradeep Singh

3,6323 gold badges33 silver badges42 bronze badges

Comments

Nandu · Accepted Answer · 2013-02-22 09:08:30Z

2

Try the following code,

 $insert=("INSERT INTO phpbb_members (emailAddress, uid, valid, firstandlast, propic, memberName) VALUES ('{$me['email']}', '{$uid}', '1', '{$me['name']}', '{$propic}', '{$newuser}')");
mysql_query($insert) or die('Error, insert query failed');

edited Feb 22, 2013 at 9:08

Nandu

3,1268 gold badges37 silver badges51 bronze badges

answered Dec 1, 2010 at 17:53

Chandrakiran K S

513 bronze badges

Collectives™ on Stack Overflow

PHP MySQL insert not working

6 Answers 6

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related