Rails User Model not being assigned an ID when using User.create()

Question

I tried looking for an answer but they were all using User.new etc and not create.

When using User.create() in console with valid attributes I'm getting a User created with nil for ID and nil for the timestamps.

Here is my user Model.

 class User < ApplicationRecord
  attr_writer :name, :email
  before_save {self.email = email.downcase}

  validates :username, presence:true,
                       length: {maximum: 30},
                       uniqueness:true


  VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-]+(\.[a-z\d\-]+)*\.[a-z]+\z/i
  validates :email, presence:true,
                    length: {maximum:200},
                    format: {with: VALID_EMAIL_REGEX},
                    uniqueness: {case_sensitive: false}

  has_secure_password

  validates :password, presence: true,
                       length: {minimum:6}

end

In the rails console I'm using

User.create(username:"oiuedhioj", email:"[email protected]",password:"test",password_confirmation:"test")

And getting back

<User id: nil, username: "Damhan", email: nil, created_at: nil, updated_at: nil, password_digest: "$2a$10$oGtRgcHigaHh/UCVX4QdM.AOgyGur8Oud5MyKZheUcQ...">

frank184 · Accepted Answer · 2017-04-16 21:56:22Z

6

Try doing the creation in the rails console.

Returning a record without an Id or timestamps is a sign of an invalid record.

user = User.create(...)
user.valid?
=> false
user.errors.any?
=> true

answered Apr 16, 2017 at 21:56

frank184

3,5981 gold badge19 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

marmeladze · Accepted Answer · 2017-04-16 21:41:49Z

1

You've set only name and email as writable. Include id and other properties on that list. Or if your rails version is 4+, use strong parameters in your controller.

#user_controller.rb

...
private

def user_params
  params.require(:user).permit(:id, :name, :email ... )
end
...

answered Apr 16, 2017 at 21:41

marmeladze

6,5863 gold badges28 silver badges49 bronze badges

1 Comment

frank184 Over a year ago

Rails adds all columns as accessible by default. What your thinking of is attr_accessible from Rails 3.

AnoE · Accepted Answer · 2017-04-16 22:02:26Z

1

In addition to the tips you already got, use create! and save! etc. instead of their complements to get an exception on error, and thus fail-fast and hence easier to debug code. Only use the variants without ! if you have a good reason. As you have to manually check for errors anyway, having proper exceptions is usually much more cleaner.

answered Apr 16, 2017 at 22:02

AnoE

8,4151 gold badge27 silver badges39 bronze badges

6 Comments

frank184 Over a year ago

Nah don't use ! in production code. Unless you're prepared to catch the exceptions. AR was designed to fail because of validation, without raising exceptions. This way you can complete the request and simply respond with the form with error fields when these are present.

AnoE Over a year ago

Yes, absolutely use ! in production. Validations work just fine with it. Obviously you do catch the exception of you expect one to happen and know how to handle it! Manually checking for errors just is an open invitation for the hardest kinds of bugs. Google "fail fast" to see what I mean. @fbelanger

frank184 Over a year ago

No do not use bang in production on AR. Sure use raising exceptions elsewhere but your wrong to raise exceptions for each possible validation. Reason being this forces manual checking (catching). While sending a object with errors back to the form will highlight fields. stackoverflow.com/questions/1761076/…

AnoE Over a year ago

@fbelanger, it makes zero sense for us to discuss this back and forth like this. I gave my arguments which go way beyond validation and won't continue. Never mind.

frank184 Over a year ago

It makes no sense because all you did is puke your argument without really discussing anything assuming your righteousness. At least I argued using your proposal. I understand very well what fail fast I don't need to google, plus doesn't apply here. Fail fast from a DB layer sure, fail fast a AR record have you not read basic error handling with Rails? After you catch your exception you'll do what rails would of done or something far worst and unmaintainable.

|

Collectives™ on Stack Overflow

Rails User Model not being assigned an ID when using User.create()

3 Answers 3

Comments

1 Comment

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related