Dynamics CRM: JavaScript GET request is not retrieving records using Web.Api

Question

I have written following JS function on Incident form to retrieve Contract Lines, but function is not doing anything. I have verified the Fetch Query and it returns results. So data is definitely there. I have debugged it and looks like "this.readyState == 4" is false.

Can anyone please suggest me what is wrong with my code. Do I need to add any assemblies?

Thanks

function Test() {

    var customerId = Xrm.Page.getAttribute("parentcustomer").getValue();
    if (customerId == null) {
        return;
    }

    var fetchXml = "<fetch version='1.0' output-format='xml-platform' mapping='logical' distinct='true'>" +
        "<entity name='contractdetail'>" +
        "<attribute name='contractid' />" +
        "<attribute name='contractdetailid' />" +
        "<filter type='and'>" +
        "<condition attribute='statuscode' operator='in'>" +
        "<value>2</value>" +
        "<value>1</value>" +
        "</condition>" +
        "<condition attribute='customerid' operator='eq' value='" +
        customerId[0].id +
        "' />" +
        "</filter>" +           
        "</entity>" +
        "</fetch>";

    var uri = "/contractdetail?fetchXml=" + encodeURIComponent(fetchXml);
    var clientUrl = Xrm.Page.context.getClientUrl();
    var webAPIPath = "/api/data/v8.1";   
    uri = clientUrl + webAPIPath + uri;

    var request = new XMLHttpRequest();
    request.open("GET", encodeURI(uri), false);
    request.setRequestHeader("Accept", "application/json");
    request.setRequestHeader("Content-Type", "application/json; charset=utf-8");
    request.setRequestHeader("OData-MaxVersion", "4.0");
    request.setRequestHeader("OData-Version", "4.0");
    request.onreadystatechange = function() {
        if (this.readyState == 4 /* complete */) {
            request.onreadystatechange = null;

            switch (this.status) {
                case 200: // Success with content returned in response body.
                case 204: // Success with no content returned in response body.
                    var data = JSON.parse(this.response);
                    if (data && data.value) {
                    for (var indexContractLine = 0; indexContractLine < data.value.length; indexContractLine++) {
                        alert(data.value[indexContractLine].contractdetailid);
                        //alert(data.value[indexContractLine]['@odata.etag']);
                    }
                }
                    break;
                default: // All other statuses are unexpected so are treated like errors.
                    var error;
                    try {
                        error = JSON.parse(request.response).error;
                    } catch (e) {
                        error = new Error("Unexpected Error");
                    }
                    alert(error);
                    break;
            }

            if (this.status == 200) {
                var data = JSON.parse(this.response);
                if (data && data.value) {
                    for (var indexContractLine = 0; indexContractLine < data.value.length; indexContractLine++) {
                        alert(data.value[indexContractLine].contractdetailid);
                        alert(data.value[indexContractLine]['@odata.etag']);
                    }
                } else {
                    var error = JSON.parse(this.response).error;
                    alert(error.message);
                }
            }
        };
        request.send();
    }
}

Look can help code: github.com/jlattimer/CRMRESTBuilder ... its awesome — KingRider
– KingRider, Commented May 9, 2017 at 19:39

Alex · Accepted Answer · 2017-04-20 11:02:56Z

4

Inside onreadystatechange replace this with request

Here's a sample bit of code straight out of a production environment (note: this is a POC, it's not meant to be copy-pasted in your code) to show how it should end up looking like:

var xhttp = new XMLHttpRequest();
xhttp.onreadystatechange = function () {
    if (xhttp.readyState == 4) {
        if (xhttp.status == 200) {
            xhttp.onreadystatechange = null; // avoid memory leaks
            var data = JSON.parse(xhttp.response);
            onsuccess(data);
        }
        else {
            var error = JSON.parse(xhttp.response).error;
            onerror(error);
        }
    }
};

edited Apr 20, 2017 at 11:02

answered Apr 20, 2017 at 10:57

Alex

23.3k4 gold badges43 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Scorpion Over a year ago

Thanks @Alex, I think I am missing something here. Code is exactly as per your recommendations now but it is still not hitting this condtion 'if (request.readyState == 4)'

Scorpion Over a year ago

I am just being silly here. Actually we are in process to upgrade to 365 and the organization I was working is still on v8.0. Now readyState is 4 but status 404.

Aron · Accepted Answer · 2017-04-20 11:52:47Z

2

You might want to install Jason Lattimer's CRM RESTBuilder solution to do further testing.

https://github.com/jlattimer/CRMRESTBuilder

It provides a GUI to create Web API queries, which you can then test and modify to your liking.

answered Apr 20, 2017 at 11:52

Aron

3,9353 gold badges16 silver badges22 bronze badges

Collectives™ on Stack Overflow

Dynamics CRM: JavaScript GET request is not retrieving records using Web.Api

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related