Insert Data in to ms access C# ASP.Net

Question

i am trying to insert data from a form to msaccess database i have the current code

OleDbConnection con = new OleDbConnection();
OleDbCommand cmd = new OleDbCommand();
con.ConnectionString = @"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=C:\Users\kunz\Documents\Visual Studio 2010\WebSites\Assignment_2_Mark_2\App_Data\nuclearpopsicledb.mdb";
cmd.Connection = con;
string sql = "insert into users values('"+tbUname.Text+"','"+tbPass.Text+"','"+tbName.Text+"','"+tbEmail.Text+"','"+tbEmail.Text+"')";

try
{
    con.Open();
    cmd.CommandText = sql;
    cmd.ExecuteNonQuery();
    con.Close();
    Label1.Text = "TRY";
}
catch(Exception ex)
{
    Label1.Text = ex.ToString();
    con.Close();
}

my data base is structured like:

but when ever i run it i get an error like

System.Data.OleDb.OleDbException: Number of query values and destination fields are not the same. at System.Data.

i am not sure what i am doing wrong i am a beginner in C#

Your objects that implement IDisposable such as OleDbConnection are not being handled properly. Wrap them in a using statement. — mason
– mason, Commented Apr 25, 2017 at 14:59
I understand this is probably a learning assignment, but you are storing plaintext passwords in the database. This is a big security violation. Passwords should be one way hashed and encrypted, never stored in plaintext. — mason
– mason, Commented Apr 25, 2017 at 14:59

interesting-name-here · Accepted Answer · 2017-04-25 15:01:29Z

3

You have an extra email you are passing:

cmd.Parameters.AddWithValue("@userName", tbUname.Text.Trim());
cmd.Parameters.AddWithValue("@password", tbPass.Text.Trim());
cmd.Parameters.AddWithValue("@Name", tbName.Text.Trim());
cmd.Parameters.AddWithValue("@Email", tbEmail.Text.Trim());

string sql = 
    "insert into users " +
    "values(@userName, @password, @Name, @Email)";

edited Apr 25, 2017 at 15:01

answered Apr 25, 2017 at 14:53

interesting-name-here

1,8901 gold badge22 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Craftx398 Over a year ago

is this the best way to do it is there a better way like to prevent sql injections

mason Over a year ago

@GibralterTop Then show how to do parameters. Don't show how to do things the incorrect way.

interesting-name-here Over a year ago

Parameters are great for preventing sql injection. But you also need to hash that pass.

interesting-name-here Over a year ago

Else you or some malicious user might feel a little curious one day and try out some email password combinations on facebook, amazon, bank of america, etc

interesting-name-here · Accepted Answer · 2017-04-28 18:57:34Z

1

Actually your table contains four values, but you are passing 5 values in that query. That is the mistake.

Your Code:

string sql = "insert into users values('"+tbUname.Text+"','"+tbPass.Text+"','"+tbName.Text+"','"+tbEmail.Text+"','"+tbEmail.Text+"')";

tbEmail.Text is repeating Twice.

edited Apr 28, 2017 at 18:57

interesting-name-here

1,8901 gold badge22 silver badges35 bronze badges

answered Apr 25, 2017 at 15:02

user7415073

3004 silver badges25 bronze badges

Collectives™ on Stack Overflow

Insert Data in to ms access C# ASP.Net

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related