Ember JS tutorial: TypeError: Cannot read property 'maps' of undefined

Question

I am currently running through the official EmberJS tutorial on their website and I'm on this part. Everything works perfectly in the app itself when I run ember serve but the problem is when I run the unit tests for the new service. I am running ember test --server and I get an error that I took a screenshot of below:

The unit test code:

import { moduleFor, test } from 'ember-qunit';
import Ember from 'ember';

const DUMMY_ELEMENT = {};

let MapUtilStub = Ember.Object.extend({
  createMap(element, location) {
    this.assert.ok(element, 'createMap called with element');
    this.assert.ok(location, 'createMap called with location');
    return DUMMY_ELEMENT;
  }
});

moduleFor('service:maps', 'Unit | Service | maps', {
  needs: ['util:google-maps']
});

test('should create a new map if one isnt cached for location', function (assert) {
  assert.expect(4);
  let stubMapUtil = MapUtilStub.create({ assert });
  let mapService = this.subject({ mapUtil: stubMapUtil });
  let element = mapService.getMapElement('San Francisco');
  assert.ok(element, 'element exists');
  assert.equal(element.className, 'map', 'element has class name of map');
});

test('should use existing map if one is cached for location', function (assert) {
  assert.expect(1);
  let stubCachedMaps = Ember.Object.create({
    sanFrancisco: DUMMY_ELEMENT
  });
  let mapService = this.subject({ cachedMaps: stubCachedMaps });
  let element = mapService.getMapElement('San Francisco');
  assert.equal(element, DUMMY_ELEMENT, 'element fetched from cache');
});

From the tutorial, my understanding is that this.subject({ cachedMaps: stubCachedMaps }) will set up all the maps for me but it seems the service itself might be undefined, leading to no property maps. Is this right? What could be causing this?

System specs from running ember --version:

ember-cli: 2.13.0
node: 6.8.1
os: darwin x64

yes, much like. I thought I was insane so I started copy pasting their code. This is broken. I'll wait to see if anyone answers here — codyc4321
– codyc4321, Commented May 12, 2017 at 17:38

cythrawll · Accepted Answer · 2017-05-21 04:34:03Z

3

So ran into the same thing. Looks like between each test the previous stub got wiped. so I added it again in the second test and it worked great:

test('should use existing map if one is cached for location', 
  function(assert) {
    assert.expect(1);
    let stubCachedMaps = Ember.Object.create({
      sanFrancisco: DUMMY_ELEMENT
    });
    let stubMapUtil = MapUtilStub.create({ assert });
    let mapService = this.subject({ mapUtil: stubMapUtil, cachedMaps: stubCachedMaps });
    let element = mapService.getMapElement('San Francisco');
    assert.equal(element, DUMMY_ELEMENT, 'element fetched from cache');
});

answered May 21, 2017 at 4:34

cythrawll

1363 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

myartsev · Accepted Answer · 2017-05-10 16:52:09Z

1

The test code you posted should work, so the problem must be elsewhere.

Can you compare the rest of the code to the completed version of the tutorial app? You can clone the repo @ https://github.com/ember-learn/super-rentals

All the tests run fine, including the maps service.

answered May 10, 2017 at 16:52

myartsev

1,2322 gold badges14 silver badges23 bronze badges

1 Comment

Sticky Over a year ago

I did a diff but not sure what to make of the results. Here's the link to the diff.txt I made: github.com/Sticksword/ember-super-rentals-tutorial/blob/master/… Alternatively can just clone my repo and then do git diff on the official ember repo as a separate remote.

jakkubu · Accepted Answer · 2017-06-06 11:02:23Z

1

I run at the same thing, too. The solution by @cythrawll works, but it's not the root cause of TypeError: Cannot read property 'maps' of undefined error.

In tutorial they forget to add

<script src="https://maps.googleapis.com/maps/api/js?v=3.22"></script>

in test/index.html file. Issue is already reported.

answered Jun 6, 2017 at 11:02

jakkubu

431 silver badge4 bronze badges

1 Comment

lsborg Over a year ago

Still the utility class should be mocked like @cythrawll did

Collectives™ on Stack Overflow

Ember JS tutorial: TypeError: Cannot read property 'maps' of undefined

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related