Calling an instance of a class from onclick

Question

I have this inside my html file:

<div class="messages">
      <input id="msg" type="text" name="fname">
      <input type="submit" onclick="general.add.call()" value="Send">
      <input type="submit" onclick="viewMsgs()" value="view messages">
    </div>

and in my js file

(function(){
  var general = new Channel();
  var rich = new Person('Rich');
  var rob = new Person('Rob');
  var message = new Message(rich, rob, "Hello!");
})()

and above that I have:

class Channel {
  constructor() {
    this.messages = [];
  }
  add(msg) {
    this.messages.push(msg)
  }

why is it saying that general is undefined?

It's because you nested the entire variable decleration inside function(){ for some reason — Koby Douek
– Koby Douek, Commented May 9, 2017 at 12:51
Variables live within an execution context. general exists within the execution context that it was declared, i.e. of the IIFE (function(){...})(), and can't be accessed from outside. — RobG
– RobG, Commented May 9, 2017 at 13:04

Quentin · Accepted Answer · 2017-05-09 12:51:39Z

1

general is a local variable that exists only inside the IIFE that you wrapped around your code.

It isn't a global, so you can't access it as a global.

Bind your event handler using addEventListener (inside the IIFE) instead of using an onclick attribute.

answered May 9, 2017 at 12:51

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Calling an instance of a class from onclick

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related