Rails, checkbox

Question

I don't know how to return checked values. There is my code

controller:

  def index

    // there I would like to get checked cities

    respond_to do |format|
      format.html # index.html.erb
      format.xml  { render :xml => @cities }
    end

  end


viewer:

  <%= render 'form' %>


_form:

  <% for cities in Database.find(:all) %>
  <div>
    <%= check_box_tag cities.city1 %>
    <%= cities.city1 %>
  </div>
  <% end %>

EDIT

I tried:

@cities = Database.find(:all)
params[:cities].each do |city|
  ...
end

and

<% for city in @cities %>
<%= check_box_tag "cities[]", city.id %> <%= city.city1 %>
<% end %>

but got error:

You have a nil object when you didn't expect it!
You might have expected an instance of Array.
The error occurred while evaluating nil.each

Bohdan · Accepted Answer · 2010-12-09 11:29:16Z

5

Hi Your problem seems to be similar to HABTM through checkboxes try

<%form_tag "some_action", :method => :post do %>
  <% Database.find(:all).each do |city| %>
    <div>
      <%= check_box_tag "cities[]",city.city1, :false %>
      <%= citiy.city1 %>
    </div>
  <% end %>
<%end%>

and inside controller

def some_action
  if !request.post?
    @cities = Database.find(:all)
    render 'view'
  else
    params[:cities].each do |city|
      ...
    end
    redirect_to view_path
  end
end

edited Dec 9, 2010 at 11:29

answered Dec 8, 2010 at 14:01

Bohdan

8,4287 gold badges44 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Bohdan Over a year ago

One more thing it's a bad idea to make requests to the db from view You should do that inside controller

Martynas Over a year ago

I tried request to db from controller, but I got error. I think is something wrong with params[:cities].each do|city| .. end because without this I can check boxes.

Bohdan Over a year ago

you don't make any difference between POST and GET requests To make params[:cties] avaliable you have to send data from your form

Mark Swardstrom · Accepted Answer · 2010-12-08 15:00:37Z

2

To do this you'll want to iterate over the list of cities and add a check_box_tag with the name "cities[]" for each.

I usually provide the list as a variable to use in the view. Do the Database.find in the controller.

<% for city in @cities %>
  <%= check_box_tag "cities[]", city.id %> <%= city.name %>
<% end %>

Note - if no checkboxes are checked, nothing will be submitted for the param - ie, there won't be a 'cities[]' param at all. You may need to add this depending on the logic of your search. If so, add to the form...

<%= hidden-field_tag "cities[]", '' %>

Or you can handle it in the controller.

answered Dec 8, 2010 at 15:00

Mark Swardstrom

18.3k6 gold badges74 silver badges75 bronze badges

2 Comments

Martynas Over a year ago

something wrong with params[:cities].each do |city| ... end because without this I can check boxes (but only check, not get params)

Mark Swardstrom Over a year ago

The error is due to the @cities variable being nil. Create @cities in the controller action.

Samo · Accepted Answer · 2010-12-08 18:23:21Z

1

Put a debugger in your controller code. What happens when you inspect your params? Is there anything similar to params[:cities]? If so, what's in there?

answered Dec 8, 2010 at 18:23

Samo

8,24013 gold badges63 silver badges96 bronze badges

Collectives™ on Stack Overflow

Rails, checkbox

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related