Switch is not properly working in javascript

Question

I have a switch statement which has several cases. These cases compare values and assign a text to a variable. But when I try to execute this switch, it always executes the default case. But my condition is true.. Why?

Here is my value

Apartment

Here is my code

var rental_cat = $('#rentals_type').val();
alert(rental_cat);
var rental_type = "";
switch (rental_cat) {
case (rental_cat == "Apartment"): 
    rental_type='daily';
    alert(rental_type);
    break;
case (rental_cat == "Office"):
    rental_type='work_daily';
    alert(rental_type);
    break;
default:
    rental_type='other';
    alert(rental_type);
    break;
}

When I execute this switch, it always gives me "other"

javascript switch syntax you got dont seem correct: w3schools.com/js/js_switch.asp — Mosd
– Mosd, Commented May 12, 2017 at 14:01

Pablo Darde · Accepted Answer · 2017-05-12 13:59:03Z

3

Remove the conditional expression inside the "case" clause.

Try this:

var rental_cat = $('#rentals_type').val();

    alert(rental_cat);

    var rental_type = "";

    switch (rental_cat) {

    case "Apartment": 
                                        rental_type='daily';
                                        alert(rental_type);
                                        break;

    case "Office":
                                        rental_type='work_daily';
                                        alert(rental_type);
                                        break;

    default:
                                        rental_type='other';
                                        alert(rental_type);
                                        break;
}

answered May 12, 2017 at 13:59

Pablo Darde

6,52211 gold badges44 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Thomas Over a year ago

@AshishVyas maybe you need to trim() the input?

Pablo Darde Over a year ago

Hi @AshishVyas, it's working for me. You can check here jsfiddle.net/pablodarde/wg1wdcd7

user7596515 Over a year ago

Thanks a lot @Thomas. after trim() that result, it works :)

Lennholm · Accepted Answer · 2017-05-12 14:06:42Z

0

switch (rental_cat) {
  case (rental_cat == "Apartment"):

is equivalent to

switch (rental_cat) {
  case true:

which in turn is equivalent to

if (rental_cat === true)

You don't put a condition in the case, the condition is created as an equality check between the switch and the cases, so it should be like this instead:

switch (rental_cat) {
  case "Apartment":

answered May 12, 2017 at 14:06

Lennholm

7,5301 gold badge23 silver badges32 bronze badges

Comments

Thomas · Accepted Answer · 2017-05-12 14:40:10Z

0

a switch is not the right structure to deal with this problem. Here I'd recommend a map:

var rentalTypesByCat = {
    DEFAULT:        "other",

    "Apartement":   "daily",
    "Office":       "work_daily",
}

var rental_cat = $('#rentals_type').val();
console.log("rental_cat:", rental_cat);

var rental_type = rentalTypesByCat[rental_cat] || rentalTypesByCat.DEFAULT;
console.log("rental_type:", rental_type);

or if you need it a bit more explicit (for example because some of your mapped values may be falsy themselves):

var rental_type = rentalTypesByCat[rental_cat in rentalTypesByCat? rental_cat: "DEFAULT"];
console.log("rental_type:", rental_type);

answered May 12, 2017 at 14:40

Thomas

12.8k1 gold badge16 silver badges31 bronze badges

Collectives™ on Stack Overflow

Switch is not properly working in javascript

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related