Easy: HTML/Javascript Can't get this button to work?

Question

I'm just starting to learn Javascript and following a tutorial. I've copied this code verbatim but it's just not doing what it's supposed to be doing. The video is from 2015 so maybe something about the language has changed? I have no idea, any help will be appreciated, thanks

<!DOCTYPE html>
<html>
<head>
  <title>JavaScript Example</title>
  <script type="text/javascript">
    function substitute() {
      var myValue = document.getElementById('myTextBox').value;

      if (myValue.length === 0) {
        alert('Please enter a real value in the text box!');
        return;
      }

      var myTitle = document.getElementById('title');
      title.innerHTML = myValue;

    }
  </script>

</head>
<body>
  <h1 id="title">JavaScript Example</h1>

  <input type="text" id="myTextBox" />
  <input type="submit" value="Click Me" onclick="substitute();" />

</body>
</html>

I have tested this, and it works correctly. Suggesting it gets closed. — Travis Heeter
– Travis Heeter, Commented May 21, 2017 at 18:58

Prajwal · Accepted Answer · 2017-05-21 18:55:14Z

1

make it,

<input type="text" id="myTextBox">
<input type="submit" value="Click Me" onclick="substitute();">

You created a function substitute but trying to call substitut.

edited May 21, 2017 at 18:55

answered May 21, 2017 at 18:52

Prajwal

4,0585 gold badges30 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Rob Over a year ago

The <input> tag has no closing slash.

Prajwal Over a year ago

yep. that one too.

Adamwuh Over a year ago

I noticed the substitute thing, but that didn't change it. And removing the slashes doesn't seem to do it either. It might be worth noting I'm working and previewing with brackets.

Ehsan Amiri · Accepted Answer · 2017-05-21 21:30:41Z

0

Variable title hasn't been defined. You should change it to this:

myTitle.innerHTML = myValue;

answered May 21, 2017 at 21:30

Ehsan Amiri

1512 silver badges6 bronze badges

2 Comments

Pankaj Shukla Over a year ago

It works with title.innerHTML as well. Did you try running code in browser?Line var myTitle = document.getElementById('title'); is not being used though.

Ehsan Amiri Over a year ago

I had not, but I just did and it works as you said. I don't understand how?

Collectives™ on Stack Overflow

Easy: HTML/Javascript Can't get this button to work?

2 Answers 2

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related