Why PHP function is returning Only the one row from mysql

Question

I am fetching data from MYSQL database and Looping through the result but its returning only one row !!! can any one explain what's wrong

 function getAll()
 {
    global $con;

    $SQL  = "SELECT * FROM users";

    $stmt = $con->query($SQL);

    if($stmt->num_rows > 0){

        while($row = $stmt->fetch_row())
        {
            return $row;
        }
    }
 }

lotfio · Accepted Answer · 2017-06-01 02:18:36Z

5

The return should be outside the while loop !

Here is how you can get all the rows :

     function getAll()
     {
        global $con;

        $SQL  = "SELECT * FROM users";

        $stmt = $con->query($SQL);

        if($stmt->num_rows > 0){

            $arr = array();

            while($row = $stmt->fetch_row())
            {
                $arr[] = $row;
            }
            return $arr;
        }
     }

Or you can do something like this return a generator and loop through :

function getAll()
     {
        global $con;

        $SQL  = "SELECT * FROM users";

        $stmt = $con->query($SQL);

        if($stmt->num_rows > 0){


            while($row = $stmt->fetch_row())
            {
                yield $row;
            }
        }
     }

see the result here !

echo '<pre>';

foreach (getAll() as $value) {
 print_r($value);
}

edited Jun 1, 2017 at 2:18

answered Jun 1, 2017 at 2:04

lotfio

1,9362 gold badges20 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Akshay Mahajan Over a year ago

Thank you so much that's what i was looking for :)

lotfio Over a year ago

You are welcome :) accept the answer pls if solved ur problem :)

Enstage · Accepted Answer · 2017-06-01 02:05:45Z

0

Once you hit a return statement all execution of that function stops. You cannot return multiple times.

You can either return an array of all rows:

function getAll()
{
    global $con;

    $SQL  = "SELECT * FROM users";

    $stmt = $con->query($SQL);

    if($stmt->num_rows > 0) {
        while($row = $stmt->fetch_row())
        {
            $array[] = $row;
        }
        return $array;
    }
 }

Or use it as a generator (probably not what you want):

function getAll()
{
    global $con;

    $SQL  = "SELECT * FROM users";

    $stmt = $con->query($SQL);

    if($stmt->num_rows > 0){

        while($row = $stmt->fetch_row())
        {
            yield $row;
        }
    }
}

answered Jun 1, 2017 at 2:05

Enstage

2,13715 silver badges20 bronze badges

2 Comments

Akshay Mahajan Over a year ago

i think no need to use loop to get more than one row mysqli_fetch_all one liner for that.

Enstage Over a year ago

No, this is how its done. There is a way to get all at once, but its just easier to do it this way, especially with a generator.

Collectives™ on Stack Overflow

Why PHP function is returning Only the one row from mysql

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related