Better way to parse nullable double value from sql reader

Question

Is there a better way to parse SqlDecimal from SqlDataReader to double than this?

class test {
    public double? Qte { get; set; }
}

SqlDataReader reader = cmd.executeReader();
reader.Read();

test t = new test() {
    Qte = (reader["DL_Qte"] == DBNull.Value) ? (double?)null : double.Parse(reader["DL_Qte"].ToString())
}

Whats reader? If it's a SqlDataReader you relaise it has a GetDouble method? — Liam
– Liam, Commented Jun 14, 2017 at 14:58
Possible duplicate of How to get float value with SqlDataReader? — Liam
– Liam, Commented Jun 14, 2017 at 15:00
If it's a decimal or money in database, why don't you store it as decimal in your model? — Tim Schmelter
– Tim Schmelter, Commented Jun 14, 2017 at 15:04

rory.ap · Accepted Answer · 2017-06-14 15:19:06Z

3

Here's the way I'd do it:

double d = reader.GetFieldValue<double>(reader.GetOrdinal("DL_Qte"));

GetFieldValue<T> is only available since .NET 4.5, so you can also do this:

double d = reader.GetDouble(reader.GetOrdinal("DL_Qte"));

EDIT:

To address the issue with nullable and DB null you're having, you could do something like this:

int columnIndex = reader.GetOrdinal("DL_Qte");

double? d = !reader.IsDBNull(columnIndex) ? 
    reader.GetFieldValue<double>(columnIndex) : new double?();

edited Jun 14, 2017 at 15:19

answered Jun 14, 2017 at 15:00

rory.ap

35.7k15 gold badges104 silver badges199 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

ebelair Over a year ago

I get a System.InvalidCastException Qte is nullable (double?)

rory.ap Over a year ago

Then use double? instead of double.

ebelair Over a year ago

I get System.Data.SqlTypes.SqlNullValueException This method cannot be called on null values

rory.ap Over a year ago

@ScottChamberlain -- I've run into trouble in the past with just null when using a ternary operator. I can't remember in what context or what happened, but it introduced a bug, and the solution was using this approach, which I've used ever since.

Scott Chamberlain Over a year ago

I think I know the quirk you are talking about and I think it only applies when the true condition of the operator is null and it can't infer the type, the false condition does not have the same problem.

Tim Schmelter · Accepted Answer · 2017-06-14 15:08:00Z

1

If it's a decimal or money in database, why don't you store it as decimal in your model? You should also not parse a decimal to string and then to double, use the right method:

class Test {
    public decimal? Qte { get; set; }
}

...

int columnIndex = reader.GetOrdinal("DL_Qte");
decimal? qte = null;
if(!reader.IsDBNull(columnIndex))
    qte = reader.GetDecimal(columnIndex);  // <----- !!!
Test t = new Test { Qte = qte };

answered Jun 14, 2017 at 15:08

Tim Schmelter

462k79 gold badges721 silver badges981 bronze badges

Collectives™ on Stack Overflow

Better way to parse nullable double value from sql reader

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related