Implementation of Overloaded Functions

Question

In my header file, I have this:

std::string StringExtend(const std::string Source, const unsigned int Length, const bool Reverse);
std::string StringExtend(const std::string Source, const unsigned int Length);

In my cpp file, I have this:

std::string Cranberry::StringExtend(const std::string Source, const unsigned int Length, const bool Reverse)
{
    unsigned int StartIndex = (Source.length() - 1) * Reverse;
    short int  Increment = 1 - (Reverse * 2);

    int Index = StartIndex;

    std::string Result;

    while (Result.length() < Length)
    {
        if (Reverse) Result = Source.at(Index) + Result;
        else Result += Source.at(Index);

        Index += Increment;

        if (!InRange(Index, 0, Source.length() - 1)) Index = StartIndex;
    }

    return Result;
}

std::string Cranberry::StringExtend(const std::string Source, const unsigned int Length)
{
    return StringExtend(Source, Length, false);
}

As you can see, the second form of the function is the exact same thing with the Reverse argument omitted. Is there a way to condense this, or do I have to have a function prototype and definition for each form?

Rod · Accepted Answer · 2011-03-06 01:46:49Z

7

Use a default parameter for your Reverse parameter.

std::string StringExtend(const std::string & Source, unsigned int Length, bool Reverse = false);

Get rid of the second function:

std::string StringExtend(const std::string & Source, unsigned int Length);

edited Mar 6, 2011 at 1:46

user405725

answered Dec 17, 2010 at 17:47

Rod

56.5k3 gold badges43 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Flinsch · Accepted Answer · 2010-12-17 17:46:24Z

2

You could set a default value for the "optional" parameter, like const bool Reverse = false.

answered Dec 17, 2010 at 17:46

Flinsch

4,3591 gold badge23 silver badges29 bronze badges

2 Comments

Maxpm Over a year ago

Does that eliminate the second definition, the second prototype, or both?

Flinsch Over a year ago

It eliminates both the second prototype and its definition as well. In this case, you would only have one function (thus one prototype and one definition). Be aware that you define the default value for the optional parameter only for the prototype in the header file.

Asha · Accepted Answer · 2010-12-17 17:47:42Z

1

Yes use default argument for bool parameter. For example std::string StringExtend(const std::string Source, const unsigned int Length, const bool Reverse = false); Then there is no need of 2nd function

answered Dec 17, 2010 at 17:47

Asha

11.3k6 gold badges46 silver badges68 bronze badges

Collectives™ on Stack Overflow

Implementation of Overloaded Functions

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related