Better way to handle exception

Question

Say, I have a function which can throw 3 types of exceptions e1, e2, and e3. So, in this function there are 2 ways of handling the exception. Which is the better way and why? Example:-

public void func() {

   block1 starts

   block1 ends
   e1 can thrown from block1

   block2 starts

   block2 ends
   e2 can thrown from block2

   block3 starts

   block3 ends
   e3 can thrown from block3
}

So, now I can handle the exceptions in 2 ways:- 1. Put 3 different try catch for 3 different blocks. 2. Put a single try on all 3 blocks and have 3 catch for each exception.

Which is considered a better way to do this?

consider to move every block to its own method, it looks like the method func is doing more than one thing! — ΦXocę 웃 Пepeúpa ツ
– ΦXocę 웃 Пepeúpa ツ, Commented Jun 27, 2017 at 7:26
then you can try-catch or throw those exceptions independently in its own method — ΦXocę 웃 Пepeúpa ツ
– ΦXocę 웃 Пepeúpa ツ, Commented Jun 27, 2017 at 7:27
@ΦXocę웃Пepeúpaツ Please edit your comment next time. Doesn't this question belong in codereview.stackexchange.com ? — M. Mimpen
– M. Mimpen, Commented Jun 27, 2017 at 7:28

cse · Accepted Answer · 2017-06-27 07:48:33Z

1

It depends upon the effect of Exception.

If all exceptions are not affecting further processing then put your each exception point in separate try-catch block. So that if one exception is occurred then you can execute the line of codes which are not affected by this exception.
Put all the exceptions which are affecting further processing in a single try-catch block for better visibility and readability. Also by doing this you removes extra try-catch block. Other wise you will need to create nested try-catch block and much complex logic(because you have to stop further execution in this case).

answered Jun 27, 2017 at 7:48

cse

4,1042 gold badges23 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DDS · Accepted Answer · 2017-06-27 07:49:31Z

0

If you want to handle each exception differently then go for multiple catch but if you want to catch the exception just for printing the stacktrace and continue the execution then go for catch with multiple exception.

answered Jun 27, 2017 at 7:49

DDS

242 bronze badges

Comments

OldCurmudgeon · Accepted Answer · 2017-06-27 08:10:53Z

0

Something like this would be the most flexible:

public void block1() throws e1 {
    try {
     ...
    } catch (e12) {
       throw new e1(e12);
    }
}

public void block2() throws e2 {
    similar to block1
}

public void block3() throws e3 {
    similar to block1
}

public void func() {
    try {
       block1();
       block2();
       block3();
    } catch (stuff) {
       stuff if you need it.
    }
}

answered Jun 27, 2017 at 8:10

OldCurmudgeon

66k18 gold badges126 silver badges220 bronze badges

Collectives™ on Stack Overflow

Better way to handle exception

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related