Using value from select element in switch loop (javascript)

Question

I am trying to use values of options of dropdown menu in my loop, but i get uncaught error, all is undefined in filter1.

function filter1() {
    var x = document.getElementById("filter1").value;
    switch(x) {
        case all: 
        getElementsByClassName("1").style.display="none";
        break;
    } 
    console.log(x);
}

HTML:

 <select id="filter1" name="country" onchange="filter1()">
          <option value="all">All countries</option>
 </select>

@abhishekkannojia Can I add this as an answer. I can mention you if you would like — user8013876
– user8013876, Commented Jun 28, 2017 at 12:54

prasanth · Accepted Answer · 2017-06-28 12:56:40Z

1

You are missing the quotes to assign string in case 'all'.And add one option greater then only perform the change function

Change document.getElementsByClassName("1")[0] instead of getElementsByClassName("1") .Because the classname is the multiple selector

function filter1() {
  var x = document.getElementById("filter1").value;
  switch (x) {
    case 'all':
     console.log('work')
      //document.getElementsByClassName("1")[0].style.display = "none";
      break;
  }
  console.log(x);
}

<select id="filter1" name="country" onchange="filter1()">
          <option value="all">All countries</option>
          <option value="one">All one</option>
 </select>

answered Jun 28, 2017 at 12:56

prasanth

22.6k4 gold badges33 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Puneet · Accepted Answer · 2017-06-28 12:56:14Z

0

Use This instead

function filter1() {
    var x = document.getElementById("filter1").value;
    switch(x) {
        case "all": 
        getElementsByClassName("1").style.display="none";
        break;
    } 
    console.log(x);
}

answered Jun 28, 2017 at 12:56

Puneet

3251 silver badge12 bronze badges

Comments

marwils · Accepted Answer · 2017-06-28 13:02:23Z

0

Short answer: you forgot the quotes surrounding 'all'.

This should work:

function filter1(value) {
    switch(value) {
        case 'all': 
        //getElementsByClassName("1").style.display="none";
        console.log('all selected');
        break;
    } 
    console.log(value);
}

<select id="filter1" name="country" onchange="filter1(this.value)">
    <option value="all">All countries</option>
    <option value="us">US</option>
</select>

answered Jun 28, 2017 at 13:02

marwils

4833 silver badges10 bronze badges

Comments

eva.eis · Accepted Answer · 2017-06-28 13:02:46Z

0

may be you should use the next construction: function filter1(){ return document.getElementById("filter1").getAttributes("value").then(function(){ }) }

answered Jun 28, 2017 at 13:02

eva.eis

363 bronze badges

Collectives™ on Stack Overflow

Using value from select element in switch loop (javascript)

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related