For loop lasts infinitely javascript

Question

I have a problem in my code:

var row = ["1","2","3","4","5"];
var column = ["1","2","3","4","5"];

var arrayLength = row.length;
var arrayLength2 = column.length;
for (var i = 0; i < arrayLength; i++) {
    for (var e = 0; e < arrayLength2; e++) {
        var samples = document.querySelectorAll('[data-row-id="'+row[i]+'"][data-column-id="'+column[e]+'"]');

        for(var i = 0; i < samples.length; i++) {
            var sample = samples[i];

            sample.setAttribute('data-sample-id', row);
            console.log("Colore cambiato");
        }
    }
}

When i run it, the cycle lasts infinitely and the console.log is called up a lots of times

Where is the error? Thanks!

Gotta love those dynamic arrays

Liam Larsen
– Liam Larsen

2017-06-30 16:14:18 +00:00
Commented Jun 30, 2017 at 16:14 — Liam Larsen
– Liam Larsen, Commented Jun 30, 2017 at 16:14

Scott Marcus · Accepted Answer · 2017-06-30 16:09:21Z

3

The problem is that your inner-most loop uses the same i looping variable as your outer most loop and it's constantly changing i so that the outer loop never finishes.

Change the variable on your inner loop to a different identifier that you aren't already using in the same scope.

answered Jun 30, 2017 at 16:09

Scott Marcus

66k6 gold badges54 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Slim Shady · Accepted Answer · 2017-06-30 16:10:07Z

1

Youre using same loop i twice nested so it runs infinitely coz it always resets i in inner loop

use something else instead like k

   for(var k = 0; k < samples.length; k++) {
        var sample = samples[k];

        sample.setAttribute('data-sample-id', row);
        console.log("Colore cambiato");
    }

answered Jun 30, 2017 at 16:10

Slim Shady

1,0852 gold badges13 silver badges40 bronze badges

Collectives™ on Stack Overflow

For loop lasts infinitely javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related