C#.NET using block

Question

I want to use the "using" block in my DAL layer. Like

using (SqlConnection con = new SqlConnection("connection string"))
{
     Command object
     Reader object
}

Since the SqlConnection object in initialised in the using block i know that this connection object will be automatically disposed when the control exits the using block scope.

But i am creating Command and Reader objects inside the using block. Do i have to explicitly close them or do i have to write another "using" block for them.

Not sure.But need not write another "using" block.After block scope is over objects:Command & Reader will be disposed. — Pratik
– Pratik, Commented Dec 20, 2010 at 7:50
@Pratik, only object explicitly put in the using (...) parentheses are actually disposed. Here, the Command and Reader will not be disposed. — Lucero
– Lucero, Commented Dec 20, 2010 at 9:36

GvS · Accepted Answer · 2010-12-20 08:09:46Z

4

You should use using for the Command and Reader as well, or explicitly close them.

I normally code it like this:

var sql = "SELECT * FROM table";
using (var cn = new SqlConnection(connectionString))
using (var cmd = new SqlCommand(sql, cn)) {
}

This limits the number of identations.

edited Dec 20, 2010 at 8:09

answered Dec 20, 2010 at 7:48

GvS

52.5k16 gold badges104 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lasse V. Karlsen · Accepted Answer · 2010-12-20 07:49:26Z

3

You typically write using-blocks for those as well, ie.

using (SqlConnection con = new SqlConnection("connection string"))
{
    con.Open();
    using (SqlCommand cmd = con.CreateCommand())
    {
        cmd.CommandText = "select * from table";
        using (SqlDataReader reader = cmd.ExecuteReader())
        {
            ...
        }
    }
}

answered Dec 20, 2010 at 7:49

Lasse V. Karlsen

394k107 gold badges651 silver badges845 bronze badges

Comments

Andrew · Accepted Answer · 2010-12-20 07:50:03Z

2

It's worth writing a using block for any code that supports IDisposable interface. This way you ensure that you have done what you can to release any scarce resources.

answered Dec 20, 2010 at 7:50

Andrew

5,2752 gold badges27 silver badges45 bronze badges

Comments

Yaakov Ellis · Accepted Answer · 2010-12-20 07:48:24Z

1

You can make using blocks for any item that implements IDispose. So you can make nested using blocks for each of these, within the block for the connection, to ensure that they are properly disposed of after use.

answered Dec 20, 2010 at 7:48

Yaakov Ellis

41.7k27 gold badges135 silver badges185 bronze badges

Comments

Pabuc · Accepted Answer · 2010-12-20 08:02:12Z

0

You should use using() or finally blocks if you don't like using for your connections and readers. For readers, connection isn't closed until the reader is closed. Also I've read that using() doesn't 100% guarantee you that the connection will be closed but I don't know the reason behind that since it is converted to try - finally blocks and will be executed in any condition.

answered Dec 20, 2010 at 8:02

Pabuc

5,6488 gold badges40 silver badges52 bronze badges

Collectives™ on Stack Overflow

C#.NET using block

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related