Copy prototype functions from object in Redux reducer

Question

case "CONNECTOR_CONNECTION_FULFILLED":
    state = {
        ...state,
        appState: 'loggedIn'
    };
    state.ourPlayer = { ...action.payload.player }

    break;

So when my app fires this action, it creates a player object for my app to use. The player object has prototype methods (player.spawn(), player.killed(), etc) on it though and when I copy it this way those don't get copied.

The Redux docs strongly recommend against putting non-serializable items (like functions) in your store. If your Redux reducers modify player state, then you should make them plain objects and use reducers instead of instance methods like killed. If your reducers don't modify the player state, then you should just do state.ourPlayer = action.payload.player, — Jordan Running
– Jordan Running, Commented Jul 7, 2017 at 16:31

Dmitry Sokurenko · Accepted Answer · 2017-07-07 19:33:22Z

1

The { ...someObject } object spread syntax, as well as the Object.assign method copies only the object's own enumerable properties. Non enumerable props, the prototype props, and the prototype itself are not copied.

So, while, that's not a recommended practice in the redux world, you can create some kind of a copy constructor for your domain objects, for example:

class Player {
  constructor(anotherPlayer) {
    // copy the props of another player there
  }
}

And use it in the reducer:

case "CONNECTOR_CONNECTION_FULFILLED":
   state = {
     ...state,
     appState: 'loggedIn',
   };
   state.ourPlayer = new Player(action.payload.player)

   break;

edited Jul 7, 2017 at 19:33

answered Jul 7, 2017 at 19:16

Dmitry Sokurenko

6,1324 gold badges34 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Copy prototype functions from object in Redux reducer

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related