Replace this lambda with method reference 'Objects::nonNull'

Question

I have written code to find the latest date from a list of an object that contains Date variable.

list.stream().map(segment -> segment.lastLoad).filter(x->x!=null).max(Date::compareTo).get()

But I am getting sonar issue stating

Replace this lambda with method reference 'Objects::nonNull'.

What I am not able to figure out is where can I use Method reference stated by sonar lint issue.

.filter(x->x!=null)

Alexis C.
– Alexis C.

2017-07-21 13:00:14 +00:00
Commented Jul 21, 2017 at 13:00 — Alexis C.
– Alexis C., Commented Jul 21, 2017 at 13:00
See also stackoverflow.com/questions/28140193/…

Alexis C.
– Alexis C.

2017-07-21 13:02:17 +00:00
Commented Jul 21, 2017 at 13:02 — Alexis C.
– Alexis C., Commented Jul 21, 2017 at 13:02

Eugene · Accepted Answer · 2017-07-21 13:08:44Z

9

.filter(x->x!=null) == .filter(Objects::nonNull)

It's interesting that you already use a method reference in(but failed to see this one):

max(Date::compareTo)

Also you are obviously returning a Date but from an Optional<Date>, you should get a warning (if using IDEA) that it's not safe to call get directly on an Optional.

And you could also replace that max(Date::compareTo) with max(Comparator.naturalOrder()) since Date is already Comparable.

edited Jul 21, 2017 at 13:08

answered Jul 21, 2017 at 13:01

Eugene

122k17 gold badges219 silver badges335 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

holi-java Over a year ago

first, up-vote. I add some shortcut here, if you using IDEA, put your cursor in highlighted part, and then press ALT+ENTER, you then can see optimization options.

BeginnersSake Over a year ago

I had no idea about Objects class. Thanks to you now I know.

Holger Over a year ago

…and I recommend replacing max(Date::compareTo) with max(Comparator.naturalOrder()).

Collectives™ on Stack Overflow

Replace this lambda with method reference 'Objects::nonNull'

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related