working if else than with functions

Question

I cant for the life of me figure out why the second function is not working. I have tried using else and elif but i either get a syntax error or my second function does not show. This is just a simple bash script. Please, i need to know what i am doing wrong..

function yes() {
echo "Good boy"
}

function no() {
echo "Bad Boy"
}

echo " Did you eat this pillow? [y,n]" ; tput sgr0
read $answer

if [ "$answer" != "y" ];
then
yes

elif [ "$answer" != "n" ];
then
no

else 
exit

fi

The parameter of read must be a variable name. In read answer, "answer" is a name. In read $answer, $answer is the value of the variable named "answer". — janos
– janos, Commented Jul 22, 2017 at 8:35

l0b0 · Accepted Answer · 2017-07-22 09:07:28Z

1

You should remove the $ sign of the first "answer" variable. What's more, read supports display a prompt before you input characters, so you should change your script like this:

#!/bin/bash
function yes() {
    echo "Good boy"
}

function no() {
    echo "Bad Boy"
}

read -p " Did you eat this pillow? [y,n]" answer

if [ "$answer" != "y" ]
then
    yes
elif [ "$answer" != "n" ]
then
    no
else
    exit
fi

edited Jul 22, 2017 at 9:07

l0b0

59.7k32 gold badges155 silver badges248 bronze badges

answered Jul 22, 2017 at 8:39

NeilWang

3675 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NeilWang Over a year ago

@Red5tar Please accept my answer if you feel helpful. Thank you.

Collectives™ on Stack Overflow

working if else than with functions

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related