How to permanently remove item from array after it's index is called?

Question

My following code displays a question and its matching answer by making an array of keys and values from a dictionary and making sure both arrays have the same index that is pulled. However after a question and its answers are randomly selected I want to remove them permanently from their respective arrays until all the other items in the array have been displayed. Simply put, how can I make sure a question and set of answers are not shown again until all the items are shown or until the user gets an answer wrong? As of now my code only makes sure the same random index isn't chosen twice in a row when I want to make sure it isn't shown twice at all.

Here is my code (swift for iOS):

func randomQuestion() {


    //random question
    var questionList = Array(QADictionary.keys)
    var rand = Int(arc4random_uniform(UInt32(questionList.count)))
    questionLabel.text = questionList[rand]




    //matching answers
    var answerList = Array(QADictionary.values)
    var choices = answerList[rand]




        rightAnswerBox = arc4random_uniform(4)+1

        //create button
        var button:UIButton = UIButton()
        var x = 1



        for index in 1...4
        {

            button = view.viewWithTag(index) as! UIButton

            if (index == Int(rightAnswerBox))
            {
                button.setTitle(choices[0], for: .normal)

            }

            else {
                button.setTitle(choices[x], for: .normal)
                x += 1

            }

            func removePair() {
                questionList.remove(at: rand)
                answerList.remove(at: rand)


            }


            randomImage()

        }
    }


let QADictionary = ["Who is Thor's brother?" : ["Atum", "Loki", "Red Norvell", "Kevin Masterson"], "What is the name of Thor's hammer?" : ["Mjolinr", "Uru", "Stormbreaker", "Thundara"], "Who is the father of Thor?" : ["Odin", "Sif", "Heimdall", "Balder"]]

vacawama · Accepted Answer · 2017-07-22 23:47:37Z

1

Move your questionList to a property of the viewController so that it stays around from one call of randomQuestion to the next. Reload it only when it is empty.

Use the dictionary to find the matching answers instead of using a second array.

var questionList = [String]()

func randomQuestion() {

    //if no more questions, reload the questionList
    if questionList.isEmpty {
        questionList = Array(QADictionary.keys)
    }

    var rand = Int(arc4random_uniform(UInt32(questionList.count)))
    questionLabel.text = questionList[rand]

    //matching answers
    var choices = QADictionary[questionList[rand]]!

    questionList.remove(at: rand)

    rightAnswerBox = arc4random_uniform(4)+1

    //create button
    var button:UIButton = UIButton()
    var x = 1

    for index in 1...4
    {
        button = view.viewWithTag(index) as! UIButton

        if (index == Int(rightAnswerBox))
        {
            button.setTitle(choices[0], for: .normal)

        }
        else {
            button.setTitle(choices[x], for: .normal)
            x += 1

        }

        func removePair() {
            questionList.remove(at: rand)
        }

        randomImage()
    }
}

edited Jul 22, 2017 at 23:47

answered Jul 22, 2017 at 23:13

vacawama

155k32 gold badges283 silver badges315 bronze badges

Sign up to request clarification or add additional context in comments.

12 Comments

Captain Code Over a year ago

this code still does not suffice for what I'm trying to accomplish. I'm trying to make sure once a question from the array is asked it isn't asked again

vacawama Over a year ago

Did you try it? You might need to move where you call questionList.remove(at: rand) to the appropriate place. Do you want to remove the question immediately upon choosing it, or only when they get it right?

Captain Code Over a year ago

Yes when I wrote the code like you said I got an error under the matching answer comment for the choices variable that said "cannot call value of non-function type '[String : Array<String>]'"

Captain Code Over a year ago

I want to remove immediately upon choosing it because once any question is answered wrong I want the app to reset and all the asked question to be placed back into the array

vacawama Over a year ago

Remove the question right after getting the choices. I updated the answer.

|

Collectives™ on Stack Overflow

How to permanently remove item from array after it's index is called?

1 Answer 1

12 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

12 Comments

Your Answer

Sign up or log in

Post as a guest

Related