ASP.NET Core - How to reuse methods created in one controller in another controller?

Question

One way is to create use class inheritance, but is there any other way I could reuse methods that I created in one controller in another controller?

EDIT: should I use a custom basecontroller like this?

public class BaseController : Controller
{
    private readonly ApplicationDbContext _context;
    private readonly IIdentityService _identityService;

    public BaseController(ApplicationDbContext context, IIdentityService identityService)
    {
        _context = context;
        _identityService = identityService;
    } 

    public BaseController()
    {
    }

     //reusable methods
     public async Task<Account> GetAccount()
     {
        //code to do something, i.e query database
     }


}

public class MyController : BaseController
{
    private readonly ApplicationDbContext _context;
    private readonly IIdentityService _identityService;

    public MyController(ApplicationDbContext context, IIdentityService identityService)
    {
        _context = context;
        _identityService = identityService;
    } 

    public async Task<IActionResult> DoSomething()
    {

      var account = await GetAccount(); 

      //do something

      Return Ok();
    }
}

This may be helpful. softwareengineering.stackexchange.com/questions/264392/…. If you still insist then cleaner approach imo is to use "RedirectToAction". — Pankaj Kapare
– Pankaj Kapare, Commented Aug 3, 2017 at 2:26

vittore · Accepted Answer · 2017-08-03 02:26:21Z

7

There are several aspects we want to touch:

if code you have is useful in all controllers, most of the time it is good practice to create BaseApiController that will inherit from ApiController and put things that are used across all controllers there. (You also inherit your controllers from that class of course)
if code is some kind of business logic and is not strictly speaking related to handling http request one way or another ( i.e. you have model Square and you want to calculate area and return it from controller method). Things like that you want to refactor to specific service which might or might not be model, dedicated service, static class or something completely different

answered Aug 3, 2017 at 2:26

vittore

17.6k6 gold badges46 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

001 Over a year ago

Some methods need to query the database, so from what you are saying I should be using a custom base controller, see my example is that right?

Keith Nicholas · Accepted Answer · 2017-08-03 02:29:35Z

0

Generally when you find something you want to use in two places it's a candidate to be spun into it's own class. Then both controllers can use the common class.

answered Aug 3, 2017 at 2:29

Keith Nicholas

44.5k15 gold badges101 silver badges168 bronze badges

Collectives™ on Stack Overflow

ASP.NET Core - How to reuse methods created in one controller in another controller?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related