Scope in Rails 5 for string match returning wrong sql query

Question

I have a scope in Rails 5 that checks for the presence of a string value.

scope :category, ->(retro) {where retro: retro 
if retro.present? }

Now when this scope is called and the param from user input passed is null, the sql query generated is

'SELECT * FROM categories WHERE categories.retro IS NULL'

How do I solve this?

If the scope is null it should not called at all. I have similar scopes for integer matches which work as expected. — coder
– coder, Commented Aug 7, 2017 at 20:15

Gerry · Accepted Answer · 2017-08-07 19:55:53Z

1

Surround your where function call with parenthesis:

where(retro: retro) if retro.present?

The if was being applied to the parameter and not to the method call.

edited Aug 7, 2017 at 19:55

Gerry

10.5k3 gold badges33 silver badges40 bronze badges

answered Aug 7, 2017 at 19:43

André Guimarães Sakata

1,1898 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

André Guimarães Sakata Over a year ago

Are you sure it's this scope that's putting the where clause?

Gerry · Accepted Answer · 2017-08-07 19:56:32Z

0

scope :category, ->(retro) { where(retro: retro) if retro.present? }

Without the brackets, it's assumed that you want the if to be part of the SQL

edited Aug 7, 2017 at 19:56

Gerry

10.5k3 gold badges33 silver badges40 bronze badges

answered Aug 7, 2017 at 19:43

Igbanam

6,1025 gold badges49 silver badges75 bronze badges

1 Comment

coder Over a year ago

Thank you, this worked.I had made a mistake with the brackets.

harika · Accepted Answer · 2017-08-09 20:29:33Z

0

In Rails4, you can use in below format. I guess same applies in Rails5

scope :category, ->(retro) {
  unless retro.blank?
    where(retro: retro)
  end
end

or

scope :category

def self.category(retro)
   unless retro.blank?
    where retro: retro
  end
end

Reference link

Rails 4 - Do not scope if conditions

edited Aug 9, 2017 at 20:29

answered Aug 7, 2017 at 20:33

harika

11310 bronze badges

Collectives™ on Stack Overflow

Scope in Rails 5 for string match returning wrong sql query

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related