Getting a basic JavaScript code to work

Question

I recently started a new project, so at the moment it is quite simple code. I think there is probably just and error or something I am unaware of that is causing an issue. To a more experienced programmer, this should be an easy fix. My HTML and JavaScript is

var quotecount = 3;

function show() {
  var rand = Math.floor((Math.random() * quotecount) + 1);

  if (rand == 1) {
    document.getElementById("disp").innerHTML = "Quote 1";
    document.getElementById("quotenum").innerHTML = "This is quote 1 out of " + quotecount;
  }

  if (rand == 2) {
    document.getElementById("disp").innerHTML = "Quote 2";
    document.getElementById("quotenum").innerHTML = "This is quote 2 out of " + quotecount;
  }

  if (rand == 3) {
    document.getElementById("disp").innerHTML = "Quote 3";
    document.getElementById("quotenum").innerHTML = "This is quote 3 out of " + quotecount;
  }
}

button {
  background: #fff;
  border: 1px solid #ccc;
  padding: 5px 13px;
  outline:none;
  cursor:pointer;
}

button:hover {
  background: #282828;
  color: #fff;
}

<!DOCTYPE html>
<html>

<body>
  <button id="quoteshow" onclick="show">Click me to show a quote!</button>

  <p id="disp"></p>
  <p id="quotenum"></p>
</body>

</html>

@clabe45 It doesn't work. When I click the button, nothing happens. — Joel Banks
– Joel Banks, Commented Aug 11, 2017 at 2:42
javascript belongs in a <script> tag and you should wait for DOM to load, actually call your function, remove the tickmark ` and read console errors — ASDFGerte
– ASDFGerte, Commented Aug 11, 2017 at 2:43

Jose David Nieto Vitola · Accepted Answer · 2017-08-11 02:49:43Z

1

You need to add parenthesis to show in your onclick call in the element.

<button id="quoteshow" onclick="show()">Click me to show a quote!</button>

answered Aug 11, 2017 at 2:49

Jose David Nieto Vitola

262 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Murat Çimen · Accepted Answer · 2017-08-11 02:59:47Z

-1

var quotecount = 3;

function show() {
  var rand = Math.floor((Math.random() * quotecount)) + 1;

    if (rand == 1) {
      document.getElementById("disp").innerHTML = "Quote 1";
      document.getElementById("quotenum").innerHTML = "This is quote 1 out of " + quotecount;
    }

    if (rand == 2) {
      document.getElementById("disp").innerHTML = "Quote 2";
      document.getElementById("quotenum").innerHTML = "This is quote 2 out of " + quotecount;
    }

    if (rand == 3) {
      document.getElementById("disp").innerHTML = "Quote 3";
      document.getElementById("quotenum").innerHTML = "This is quote 3 out of " + quotecount;
    }
}

<p id="disp"></p>
<p id="quotenum"></p>

<button onclick="show()">Click me</button>

Add click button.

edited Aug 11, 2017 at 2:59

answered Aug 11, 2017 at 2:50

Murat Çimen

4834 silver badges8 bronze badges

Collectives™ on Stack Overflow

Getting a basic JavaScript code to work

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related