0

I have searched and looked for the answer but have not been able to get the answer that works.

To the question: I have created an array called backpack that can hold 5 items. I want the user to fill those 5 items. The project is supposed to be able to get back at a later time to fill in more (max 5).

This code are going to be implemented to another code that uses a menue and the user are going to be able to go from adding to the list and read the list. For example: The user goes to option 1 (to add) and adds shoes to the array. The user then goes back and in to option 2 to read whats in the list. Then the user goes back again and in to option 1 to add more items.

I have used a for loop but doesnt seems to work anyway, the error message i got is: System.IndexOutOfRangeException: 'Index was outside the bounds of the array.' Here is the code:

       string[] backPack = new string[5];
        string answer;
        for (int i = backPack.Length; i <= 5; i++)
        {
            Console.Write("Vad vill du lägga till? "); // What do you want to add.
            backPack[i] = Console.ReadLine();
            Console.Write("Vill du lägga till fler produkter i din ryggsäck?(j/n): "); (Do you want to add more items to the backpack?
            answer = Console.ReadLine().ToLower();
            if (answer == "n")
            {
                break;
            }
        }

Note that it is in Swedish (the Write lines) but i have added a comment to translate this.

Can u please help me find whats the problem?

Edited code:

     string[] backPack = new string[5];
        string answer;
        for (int i =0; i <= backPack.Length; i++)
        {
            Console.Write("Vad vill du lägga till? ");
            backPack[i] = Console.ReadLine();
            Console.Write("Vill du lägga till fler produkter i din ryggsäck?(j/n): ");
            answer = Console.ReadLine().ToLower();
            if (answer.Equals("n"))
            {
                break;
            }

        }

Now the earlier error does not happen directly but it seems the code wants to try and add a 6th item to the array. And then we get the same error again: System.IndexOutOfRangeException: 'Index was outside the bounds of the array.'

Please help.

Improve this question
4
  • 1
    What's the problem you are having? 'It doesn't seem to work' is not very descriptive. Commented Aug 12, 2017 at 11:47
  • First you should think for some kind of a storage(text file probably). How do you expect to fill something on Wednesday and to still exist 5 days after that. You need to store it. After that you can start thinking about the problems in the code. Commented Aug 12, 2017 at 11:47
  • The above code should have caused an exception to be thrown. Use a try-catch block to see what the error is. That should answer your question. Commented Aug 12, 2017 at 11:54
  • Thomas, why for (int i =0; i <= backPack.Length; i++) when the answer provided clearly saying for (int i =0; i < backPack.Length; i++) < not <= this definitely will try to add sixth element to the array. Commented Aug 12, 2017 at 12:28

2 Answers 2

Reset to default
1

Change your for loop to be 

for (int i = 0; i < backPack.Length; i++)

because you already initialized your list with size of 5, so you will count from 0 to 4 or until the user breaks the loop

[EDIT] Regarding the next part of your question, If you want to revisit the list from the last index you filled, you can use an arbitrary integer to track the last filled index, see the following example

    string[] backPack = new string[5];
    int lastIndex = 0;
    int addItem(string[] myList, int index) {
        while (index < myList.Length) {
                Console.Write("Vad vill du lägga till? "); // What do you want to add.
                myList[index] = Console.ReadLine();
                index += 1;
                Console.Write("Vill du lägga till fler produkter i din ryggsäck?(j/n): "); //(Do you want to add more items to the backpack?
                answer = Console.ReadLine().ToLower();
                if (answer == "n") {
                    break;
                }
          }
          return index;
    }
// Now you can call lastIndex = addItem(backPack, lastIndex) at each time you want to add a new item
Improve this answer
Sign up to request clarification or add additional context in comments.

3 Comments

Yeah you are right, it was so obvious when you pointed it out.
Thou i have now 2 problems. 1. When i have added 5 items it goes and tries to add a six item. And ofcourse that wont work, you get error message. 2. If i wanted to add to the array later and not all in one sitting it will get to the same problem as above. Do you have any ideas how to work around that?
it's for (int i = 0; i < backPack.Length; i++) not for (int i = 0; i <= backPack.Length; i++) be careful!
1

answer == "n" is incorrect. Use a String method to compare strings.

answer.equals("n")

Your loop is also wrong because you are starting at index 5 and the array goes from index 0 to index 4. There is no index 5.

Improve this answer

2 Comments

Yeah you are correct, it was obvious when you pointed it out. Thou i have now 2 problems. 1. When i have added 5 items it goes and tries to add a six item. And ofcourse that wont work, you get error message. 2. If i wanted to add to the array later and not all in one sitting it will get to the same problem as above. Do you have any ideas how to work around that?
@TomasZoncRinblad In a new question, post code that demonstrates your problems and we will fix it.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.