Laravel function callback

Question

I need to find certain cues in a string and call functions with these cues

Example

<?php
namespace App\Http\Controllers;
class ModulesController
{
    private $modules = [ ['name' => 'someFunction','maxNumber' => 50] ];
    public function checkFunctions($strings = NULL)
    {
     $moduleArrayId = array_search($strings ,array_column($this->modules, 'name');
     if($moduleArrayId !== FALSE)
         $this->$modules[$moduleArrayId]['name'];

    }

    public  function someFunction()
    {
       return "it works";
    }
}

And resource example

<?php
namespace App\Http\Controllers;
use App\Http\Controllers\ModulesController;

class BlockController extends Controller
{
  public function __construct()
  {
     $this->middleware('auth:members');
  }

  public function index(Request $request)
  {
     $string = "someFunction";
     $callBack = new ModulesController;
     var_dump($callBack->checkFunctions($string)); //Always its NULL
  }
}

I have to use this code like this. If I can understand this, I will try to improve it.

Jigar Shah · Accepted Answer · 2017-08-15 02:22:21Z

1

you missed ) in

$moduleArrayId = array_search($strings ,array_column($this->modules, 'name'));

That's why you are getting default value NULL all the time.

answered Aug 15, 2017 at 2:22

Jigar Shah

6,2332 gold badges32 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Pamir Işık Over a year ago

No, there is no connection.

Jigar Shah Over a year ago

you haven't returned any value

Thiago Barcala · Accepted Answer · 2017-08-15 20:26:41Z

Try this:

public function checkFunctions($strings = NULL)
{
    $moduleArrayId = array_search($strings ,array_column($this->modules, 'name'));
    if($moduleArrayId !== FALSE) {
        $method = $this->modules[$moduleArrayId]['name'];
        return $this->$method();
    }
}

Not sure how much you changed your code in order to post here, but I would suggest you to:

Use better names.
Do not instantiate/call directly a controller from other controller. Controllers should only be used to handle requests, everything else should be moved to a separate class.
Modify the structure of $modules to an associative array, so you can check if the method is defined by index, instead of using array_search. This can make your code run much faster as the size of this structure grows.

Example:

private $modules = [
    'someFunction' => [
        'maxNumber' => 50
    ]
];

// and then to check if the method is defined:
if (isset($this->modules[$strings])) {
    // ...
}

Collectives™ on Stack Overflow

Laravel function callback

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related