Android EditText with input type number make value on text change always > 0

Question

I am currently making a validation, where I have an edittext with inputtype number, used to show quantity of items bought in user's cart. I want to make sure that when the edittext's value is edited, if the value is "", "0", or "00", etc, as long as it is < 1, then the value will be set into "1".

I have tired the below's code:

        txtJumlah.addTextChangedListener(new TextWatcher() {
            @Override
            public void beforeTextChanged(CharSequence s, int start, int count, int after) {

            }

            @Override
            public void onTextChanged(CharSequence s, int start, int before, int count) {

            }

            @Override
            public void afterTextChanged(Editable s) {
                int jumlah = Integer.parseInt(txtJumlah.getText().toString());
                if(txtJumlah.getText().toString().equals("") || jumlah <= 1) {
                    txtJumlah.setText("1");
                }
                calculate();
            }
        });

But it returns a java.lang.StackOverflowError: stack size 8MB

Can anyone help me? thanks

Aidan Laing · Accepted Answer · 2017-08-25 02:57:27Z

2

When you set the text to "1" it will call afterTextChanged again and again causing an infinite loop. Try putting jumlah < 1 in your if statement instead.

answered Aug 25, 2017 at 2:57

Aidan Laing

1,3101 gold badge12 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Anshuman Jaiswal · Accepted Answer · 2017-08-25 03:19:25Z

1

replace this:

if(txtJumlah.getText().toString().equals("") || jumlah <= 1) {
     txtJumlah.setText("1");
}

by:

if(txtJumlah.getText().toString().equals("") || jumlah < 1) {
    txtJumlah.setText("1");
}

Above solution must solve the problem.

One suggestion to optimize your code:

int jumlah = Integer.parseInt(txtJumlah.getText().toString());

This can cause ParseException (if txtJumlah.getText().toString() is string rather than numbers)

edited Aug 25, 2017 at 3:19

answered Aug 25, 2017 at 3:00

Anshuman Jaiswal

5,4621 gold badge31 silver badges46 bronze badges

1 Comment

Aidan Laing Over a year ago

txtJumlah.getText() will never return null. It will always return an empty String. The only thing that could cause a NullPointerException is if the TextView was null. Even if you try to setText(null) it will convert it to an empty String.

Collectives™ on Stack Overflow

Android EditText with input type number make value on text change always > 0

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related