JavaScript function not working with anchor tag click

Question

Why this function is not working when i click on the Rate me button?

function incrementValue(){
    var value = parseInt($("#rateme").value, 10);
    value = isNaN(value) ? 0 : value;
    value++;
    $("#rateme").value = value;
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<ul>
  <li>
    <a onclick="incrementValue()">Rate me</a><input type="text" id="rateme" value="50" />
  </li>
</ul>

The function call is okay.The problem might me with the logic. jsfiddle.net/w056zv3L — Mohhamad Hasham
– Mohhamad Hasham, Commented Sep 8, 2017 at 21:02
Why would you use inline javascript event handling instead of using jQuery? — Erik Philips
– Erik Philips, Commented Sep 8, 2017 at 21:02
@ErikPhilips It start working if i change id to #number. what is the reason? — Rohit
– Rohit, Commented Sep 8, 2017 at 21:04

Djaouad · Accepted Answer · 2017-09-08 21:06:19Z

2

In jQuery, it's $("#rateme").val() not $("#rateme").value, that's for DOM elements not jQuery objects:

function incrementValue(){
    var value = parseInt($("#rateme").val(), 10);
    value = isNaN(value) ? 0 : value;
    value++;
    $("#rateme").val(value);
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<li><a onclick="incrementValue()">Rate me</a><input type="text" id="rateme" value="50" /></li>

edited Sep 8, 2017 at 21:06

answered Sep 8, 2017 at 21:02

Djaouad

22.8k4 gold badges37 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Rohit Over a year ago

It start working if i change id to #number. what is the reason?

Djaouad Over a year ago

@Rohit it's not about the id, you can change to whatever you like as long as you use it correctly, the problem is that you're calling a dom method on a jquery object, which is not correct.

Djaouad Over a year ago

It works with $('#number').value = value?! Idon't think so. Try again.

Djaouad Over a year ago

@Rohit update your question with the current code that you claim works.

Collectives™ on Stack Overflow

JavaScript function not working with anchor tag click

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related