Passing class from another class or dependency injection

Question

I'm having difficulties to understand the given code and the reason behind dependency injection. I've got the following error:

Uncaught Error: Call to undefined method Question::getFullName() in C:\xampp\htdocs\OOP\Index.php:10 Stack trace: #0 {main} thrown in C:\xampp\htdocs\OOP\Index.php on line 10.

Even if I instantiate an object of the Author class in the constructor, I keep getting a string in the Question class once I try to use getQuestion().

require 'Author.php';

class Question {
  private $author;
  private $question;

  public function __construct($question, Author $author) {
    $this->author = $author;
    $this->question = $question;
  }

  public function getAuthor() {
    $firstname = $this->author->getFirstName();
    $lastname = $this->author->getLastName();
    $fullaname = $firstname . $lastname;

    return $this;
  }

  public function getQuestion() {
    return $this->question;
  }
}

<?php

class Author {
  private $firstName;
  private $lastName;
  private $fullName;

  public function __construct($firstName, $lastName) {
    $this->firstName = $firstName;
    $this->lastName = $lastName;
  }

  public function getFirstName() {
    return $this->firstName;
  }

  public function getLastName() {
    return $this->lastName;
  }

  public function getFullName() {
    return $this->fullName = $this->firstName." ".$this->lastName;
  }
}

require 'Question.php';

$question = new Question("What is the author's name?", new Author("josel", "parayno"));

echo $question->getQuestion();
echo $question->getFullName();

tsv · Accepted Answer · 2017-09-14 06:30:12Z

2

$question really does not have getFullName method. Method getFullName exists in class Author. And after creating and "sending" to Question, when it was created method getFullName available in class Question private $author property.

But if you want to get Athor name by follow code, you need try

$question->getAuthor()->getFullName();

And if you do this, you take error again, becouse in question->getAuthor you return $this, and in this case this is a Question object. For getting author name from question object you should to do follow:

Fix getAuthor like this

public function getAuthor() 
{
    $firstname = $this->author->getFirstName();
    $lastname = $this->author->getLastName();
    return $this->author;
}

Rewite call name in you index.php like this

echo $question->getAuthor()->getFullName();

edited Sep 14, 2017 at 6:30

answered Sep 14, 2017 at 6:24

tsv

695 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nigel Ren Over a year ago

In fact - getAuthor can JUST return $this->author - the rest doesn't do anything useful in this case.

tsv Over a year ago

I am sure, in this case method getAuthor provide working with protection method by program rules. In other cases getter like that getAuthor and setters too provide very usefull and safe working with class methods and centralization of property management.

Collectives™ on Stack Overflow

Passing class from another class or dependency injection

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related