Problem with c# timer

Question

I have a method that I want to call a method (will mention as myFanc) in seperated thread every 3 seconds

The code below can easly do it,

 Timer myTimer = new Timer();
 myTimer.Elapsed += new ElapsedEventHandler( myFanc );
 myTimer.Interval = 3000;
 myTimer.Start();

The code above may cause myFanc to be called while another call to myFanc isn't finished yet

My problem is that I also want myFanc to finished before I will call her agian, so basically I want to call the method in seperated thread every 3 seconds after myFanc is finished, how can I do it?

I don't mind if the solution won't use Timer class, I just want this behavior to work..

Jim Brissom · Accepted Answer · 2011-01-08 15:21:09Z

6

Set the AutoReset property of your timer to false, then, at the end of your event handler (i.e. "myFanc"), call the Start method of your timer again.

answered Jan 8, 2011 at 15:21

Jim Brissom

33.2k4 gold badges41 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ahmed Al Hafoudh · Accepted Answer · 2011-01-08 15:30:39Z

2

At the top of myFunc put this

myTimer.Enabled = false;

and at the end when it is finished put this

myTimer.Enabled = true;

It will cause that you will temporairly disable the Timer while function is executing

answered Jan 8, 2011 at 15:30

Ahmed Al Hafoudh

8,4791 gold badge21 silver badges35 bronze badges

Comments

Felice Pollano · Accepted Answer · 2011-01-08 15:21:09Z

1

Do not use a timer, loop in the thread calling "myfanc" and use

Thread.Sleep(3000);

to insert the desired delay.

answered Jan 8, 2011 at 15:21

Felice Pollano

33.4k10 gold badges77 silver badges125 bronze badges

6 Comments

Jim Brissom Over a year ago

@Delashmate: if you are indeed using different threads already, I second this suggestion - sleeping the second thread is the preferred way of handling the delay then.

Kurru Over a year ago

@Delashmate: On what reasoning? This is an appropriate use of thread.sleep

Delashmate Over a year ago

@Jim, is Thread.Sleep consuming cpu? if so then it isn't elegant solution

Felice Pollano Over a year ago

Thread.Sleep suspend the thread, thus it does not consume CPU

Felice Pollano Over a year ago

@Delashmate event has nothing to do with Thread.Sleep. You can check that by suspending a thread for say, ten seconds ( 10000 ) the CPU comsumption of your process is 0...

|

Delashmate · Accepted Answer · 2011-01-08 15:31:55Z

This is the solution I used - thanks to Jim

using System;
using System.Timers;
using System.Threading;

class myApp
{
    public static void Main()
{
      System.Timers.Timer myTimer = new System.Timers.Timer();
      myTimer.Elapsed += new ElapsedEventHandler( myFanc );
      myTimer.Interval = 1000;
      myTimer.AutoReset = false;
      myTimer.Start();

      while ( Console.Read() != 'q' )
      {
          ;    // do nothing...
      }
    }

public static void myFanc(object source, ElapsedEventArgs e)
{
    Console.Write("\r{0}", DateTime.Now);

    Thread.Sleep(3000); //the sleep here is just to test the method, wait to be finished before another call the myFanc method is being performed
    System.Timers.Timer myTimer = new System.Timers.Timer();
    myTimer.Elapsed += new ElapsedEventHandler(myFanc);
    myTimer.Interval = 1000;
    myTimer.AutoReset = false;
    myTimer.Start();

}

}

Furnes · Accepted Answer · 2011-01-08 15:23:20Z

0

2 methods than I can think of right now

Stop and start the timer inside the myFanc method This ensures 3 seconds between each run
Wrap your code in myFanc inside a lock, this will just skip a turn if it's not finished.

Make sure you use the correct timer.. system.threading.timer is a seperate thread. The timer class in windows.forms (or something like that) isn't

answered Jan 8, 2011 at 15:23

Furnes

3821 gold badge2 silver badges19 bronze badges

Comments

Kurru · Accepted Answer · 2011-01-08 15:36:42Z

0

Use a thread and Thread.Sleep(x) like so

Thread thread = new Thread(new ThreadStart(myTimer));
thread.Start();


void myTimer()
{
    while (!exit)
    {
        myFunc();
        Thread.Sleep(3000);
    }
}

answered Jan 8, 2011 at 15:36

Kurru

14.4k18 gold badges67 silver badges87 bronze badges

1 Comment

Kurru Over a year ago

why? Its perfectly suited to introducing lag like as required here

Collectives™ on Stack Overflow

Problem with c# timer

6 Answers 6

Comments

Comments

6 Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

6 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related