232

I need to loop through a directory recursively and remove all files with extension .pdf and .doc. I'm managing to loop through a directory recursively but not managing to filter the files with the above mentioned file extensions.

My code so far

#/bin/sh

SEARCH_FOLDER="/tmp/*"

for f in $SEARCH_FOLDER
do
    if [ -d "$f" ]
    then
        for ff in $f/*
        do      
            echo "Processing $ff"
        done
    else
        echo "Processing file $f"
    fi
done

I need help to complete the code, since I'm not getting anywhere.

4
  • 114
    I know it's bad form to execute code without understanding it, but a lot of people come to this site to learn bash scripting. I got here by googling "bash scripting files recursively", and almost ran one of these answers (just to test the recursion) without realizing it would delete files. I know rm is a part of OP's code, but it's not actually relevant to the question asked. I think it'd be safer if answers were phrased using a harmless command like echo. Commented Apr 5, 2016 at 3:26
  • Similar question here: stackoverflow.com/questions/41799938/… Commented Jan 23, 2017 at 6:22
  • 2
    @Keith had similar experience, completely agree and changed the title Commented Jan 24, 2017 at 15:48
  • Warning for noobs like me, wasting hours: In most of the answers, you need to change where it says "/tmp/" directory you want to do it, example: "/home/my folder". Commented Sep 17, 2021 at 22:00

16 Answers 16

293

As a followup to mouviciel's answer, you could also do this as a for loop, instead of using xargs. I often find xargs cumbersome, especially if I need to do something more complicated in each iteration.

for f in $(find /tmp -name '*.pdf' -or -name '*.doc'); do rm $f; done

As a number of people have commented, this will fail if there are spaces in filenames. You can work around this by temporarily setting the IFS (internal field seperator) to the newline character. This also fails if there are wildcard characters \[?* in the file names. You can work around that by temporarily disabling wildcard expansion (globbing).

IFS=$'\n'; set -f
for f in $(find /tmp -name '*.pdf' -or -name '*.doc'); do rm "$f"; done
unset IFS; set +f

If you have newlines in your filenames, then that won't work either. You're better off with an xargs based solution:

find /tmp \( -name '*.pdf' -or -name '*.doc' \) -print0 | xargs -0 rm

(The escaped brackets are required here to have the -print0 apply to both or clauses.)

GNU and *BSD find also has a -delete action, which would look like this:

find /tmp \( -name '*.pdf' -or -name '*.doc' \) -delete
Sign up to request clarification or add additional context in comments.

9 Comments

This does not work as expected if there is a space in the file name (the for loop splits the results of find on whitespace).
How do you avaoid splitting on whitespace? I'm trying a similar thing and I have a lot of directories with whitespaces that screw up this loop.
because it's a very helpful answer?
@Matthew your edit didn't fix anything at all: it actually made the command only work if there's a unique found file. At least this version works if there are no spaces, tabs, etc. in filenames. I rolled back to the old version. Noting sensible can really fix a for f in $(find ...). Just don't use this method.
@DrewDormann my testing also shows that "$(find...)" makes things worse. I've undone your edit, along with making a long-overdue update of my own.
|
187

find is just made for that.

find /tmp -name '*.pdf' -or -name '*.doc' | xargs rm

7 Comments

Or find's -delete option.
One should always use find ... -print0 | xargs -0 ..., not raw find | xargs to avoid problems with filenames containing newlines.
Using xargs with no options is almost always bad advice and this is no exception. Use find … -exec instead.
@CarlWinbäck Because the syntax of the input to xargs is not the syntax that find (or any other common command) prints. xargs expects a particular kind of quote-delimited input.
Using -delete -print with find will cause it to delete the files and print filenames as it does so. That's the behavior I was looking for so figured I'd post.
|
113

Without find:

for f in /tmp/* tmp/**/* ; do
  ...
done;

/tmp/* are files in dir and /tmp/**/* are files in subfolders. It is possible that you have to enable globstar option (shopt -s globstar). So for the question the code should look like this:

shopt -s globstar
for f in /tmp/*.pdf /tmp/*.doc tmp/**/*.pdf tmp/**/*.doc ; do
  rm "$f"
done

Note that this requires bash ≥4.0 (or zsh without shopt -s globstar, or ksh with set -o globstar instead of shopt -s globstar). Furthermore, in bash <4.3, this traverses symbolic links to directories as well as directories, which is usually not desirable.

8 Comments

This method worked for me, even with filenames containing spaces on OSX
Worth noting that globstar is only available in Bash 4.0 or newer.. which is not the default version on many machines.
I dont think you need to specify the first argument. (At least as of today,) for f in /tmp/** will be enough. Includes the files from /tmp dir.
Wouldn't it be better like this ? for f in /tmp/*.{pdf,doc} tmp/**/*.{,pdf,doc} ; do
** is a nice extension but not portable to POSIX sh. (This question is tagged bash but it would be nice to point out that unlike several of the solutions here, this really is Bash-only. Or, well, it works in several other extended shells, too.)
|
38

If you want to do something recursively, I suggest you use recursion (yes, you can do it using stacks and so on, but hey).

recursiverm() {
  for d in *; do
    if [ -d "$d" ]; then
      (cd -- "$d" && recursiverm)
    fi
    rm -f *.pdf
    rm -f *.doc
  done
}

(cd /tmp; recursiverm)

That said, find is probably a better choice as has already been suggested.

Comments

22

Here is an example using shell (bash):

#!/bin/bash

# loop & print a folder recursively,
print_folder_recurse() {
    for i in "$1"/*;do
        if [ -d "$i" ];then
            echo "dir: $i"
            print_folder_recurse "$i"
        elif [ -f "$i" ]; then
            echo "file: $i"
        fi
    done
}


# try get path from param
path=""
if [ -d "$1" ]; then
    path=$1;
else
    path="/tmp"
fi

echo "base path: $path"
print_folder_recurse $path

1 Comment

Is it possible to achieve same without function?
19

This doesn't answer your question directly, but you can solve your problem with a one-liner:

find /tmp \( -name "*.pdf" -o -name "*.doc" \) -type f -exec rm {} +

Some versions of find (GNU, BSD) have a -delete action which you can use instead of calling rm:

find /tmp \( -name "*.pdf" -o -name "*.doc" \) -type f -delete

Comments

12

For bash (since version 4.0):

shopt -s globstar nullglob dotglob
echo **/*".ext"

That's all.
The trailing extension ".ext" there to select files (or dirs) with that extension.

Option globstar activates the ** (search recursivelly).
Option nullglob removes an * when it matches no file/dir.
Option dotglob includes files that start wit a dot (hidden files).

Beware that before bash 4.3, **/ also traverses symbolic links to directories which is not desirable.

Comments

9

This method handles spaces well.

files="$(find -L "$dir" -type f)"
echo "Count: $(echo -n "$files" | wc -l)"
echo "$files" | while read file; do
  echo "$file"
done

Edit, fixes off-by-one

function count() {
    files="$(find -L "$1" -type f)";
    if [[ "$files" == "" ]]; then
        echo "No files";
        return 0;
    fi
    file_count=$(echo "$files" | wc -l)
    echo "Count: $file_count"
    echo "$files" | while read file; do
        echo "$file"
    done
}

2 Comments

I think "-n" flag after echo not needed. Just test it yourself: with "-n" your script gives wrong number of files. For exactly one file in directory it outputs "Count: 0"
This doesn't work with all file names: it fails with spaces at the end of the name, with file names containing newlines and with some file names containing backslashes. These defects could be fixed but the whole approach is needlessly complex so it isn't worth bothering.
2

This is the simplest way I know to do this: rm **/@(*.doc|*.pdf)

** makes this work recursively

@(*.doc|*.pdf) looks for a file ending in pdf OR doc

Easy to safely test by replacing rm with ls

Comments

1

The following function would recursively iterate through all the directories in the \home\ubuntu directory( whole directory structure under ubuntu ) and apply the necessary checks in else block.

function check {
        for file in $1/*      
        do
        if [ -d "$file" ]
        then
                check $file                          
        else
               ##check for the file
               if [ $(head -c 4 "$file") = "%PDF" ]; then
                         rm -r $file
               fi
        fi
        done     
}
domain=/home/ubuntu
check $domain

Comments

1

There is no reason to pipe the output of find into another utility. find has a -delete flag built into it.

find /tmp -name '*.pdf' -or -name '*.doc' -delete

Comments

0

The other answers provided will not include files or directories that start with a . the following worked for me:

#/bin/sh
getAll()
{
  local fl1="$1"/*;
  local fl2="$1"/.[!.]*; 
  local fl3="$1"/..?*;
  for inpath in "$1"/* "$1"/.[!.]* "$1"/..?*; do
    if [ "$inpath" != "$fl1" -a "$inpath" != "$fl2" -a "$inpath" != "$fl3" ]; then 
      stat --printf="%F\0%n\0\n" -- "$inpath";
      if [ -d "$inpath" ]; then
        getAll "$inpath"
      #elif [ -f $inpath ]; then
      fi;
    fi;
  done;
}

Comments

0

Lots of answers here, but I was surprised that I couldn't find this very simple one:

rm -v **/*.pdf **/*.doc

Or add the -i option and rm will prompt you for each file.

Tested in fish, although it should work with most other shells, too.

Update: Also tested in zsh 5.9.

Comments

0

I think the most straightforward solution is to use recursion, in the following example, I have printed all the file names in the directory and its subdirectories.

You can modify it according to your needs.

#!/bin/bash    
printAll() {
    for i in "$1"/*;do # for all in the root 
        if [ -f "$i" ]; then # if a file exists
            echo "${i%/*}"  # Print filename only 
        elif [ -d "$i" ];then # if a directroy exists
            printAll "$i" # call printAll inside it (recursion)
        fi
    done 
}
printAll $1 # e.g.: ./printAll.sh .

OUTPUT:

> ./printAll.sh .
./demoDir/4
./demoDir/mo st/1
./demoDir/m2/1557/5
./demoDir/Me/nna/7
./TEST

It works fine with spaces as well!

Note: You can use echo $(basename "$i") # print the file name to print the file name without its path.

OR: Use echo ${i%/##*/}; # print the file name which runs extremely faster, without having to call the external basename.

2 Comments

The parameter substitution to print file name is incorrect. (Not sure if I can correct in the answer).
Thanks for your note, I corrected it ("$i" -> ${i%/*}). ${i} represents the entire path of the current file, and %/* removes everything from the end of the string up to, but not including, the last slash (/).
-2

Just do

find . -name '*.pdf'|xargs rm

1 Comment

No, don't do this. This breaks if you have filenames with spaces or other funny symbols.
-2

If you can change the shell used to run the command, you can use ZSH to do the job.

#!/usr/bin/zsh

for file in /tmp/**/*
do
    echo $file
done

This will recursively loop through all files/folders.

Comments

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.