AngularJS factory does not retain value

Question

I have created a simple factory to store a value from my authService:

app.factory("subfactory",
        function() {
            var subValue = {};
            return {
                set: set,
                get: get
            };

            function get() {
                return subValue;
            }

            function set(value) {
                subValue = value;
            }
        });

I am saving value like this in authservice - this is not full service, just snippet to show where I am saving the value using subfactory.set():

 mgr.getUser().then(function (user) {
        if (user) {
            var idToken = user.id_token;
            var dataIdToken = getDataFromToken(idToken);
            subfactory.set(dataIdToken.sub);
        } else {
            //console.log("User not logged in");
        }
    });

But when I try and read the object out in controller it is empty:

    vm.onGridLoad = function() {

        var storedValue = subfactory.get();

        console.log(storedValue);

Andrei Dragotoniu · Accepted Answer · 2017-10-05 16:03:00Z

I would write the factory in a different way, but that's just me.

app.factory("subfactory",
        function() {

           var service = {};
           service.subValue = {};

            service.save = save;

            return service;

            function save(value) {
                service.subValue = value;
            }
        });

then you inject the factory in whatever controller you need. There is no need for a get method as you return the service object and can simply use service.subValue to get the value back out. If you don't like it then feel free to change it to whatever your preference is.

The code is untested but should be close enough to solve your issue.

You don't specify what kind of angular app you have, is it a spa or not? do you reload the page after the initial save? If you do reload the page as in navigate to another page for example, your JavaScript will reload and you will lose the state saved in the factory. In that case you can store whatever you want to keep in something like the localStorage for example.

Ramesh Rajendran · Accepted Answer · 2017-10-05 13:41:43Z

0

Use return on your service

function get()
{
return mgr.getUser().then(function (user) {
        if (user) {
            var idToken = user.id_token;
            var dataIdToken = getDataFromToken(idToken);
            subfactory.set(dataIdToken.sub);
        } else {
            //console.log("User not logged in");
        }
    });
}

answered Oct 5, 2017 at 13:41

Ramesh Rajendran

38.9k49 gold badges159 silver badges241 bronze badges

Collectives™ on Stack Overflow

AngularJS factory does not retain value

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related