elixir recursion block not returning proper value

Question

I want the following block of code to return value not equal to 0 or n. But sometimes it returns values equal to 0.

def get_random(n, num) do   
   random = returns some number
   IO.puts random
   if random == n or random == 0 do
      get_random(n, num)
   end
   random
end

shouldn't it be random instead of ran in your if statement? — Pfitz
– Pfitz, Commented Oct 6, 2017 at 7:47

denis.peplin · Accepted Answer · 2017-10-06 07:56:07Z

1

You didn't set random variable second time.

Fixed code:

defmodule GetRandom do
  def get_random(n, num) do
    random = Enum.random(0..num)
    IO.puts random
    random = if random == n or random == 0 do
      get_random(n, num)
    else
      random
    end
    random
  end
end

This code can be simplified. First, if Enum.random is used, you don't need to exclude 0 after call. Just exclude it from range.

Also, use implicit value return. You don't need to set random variable second time if it is in the end of the function.

defmodule GetRandom do
  def get_random(n, num) do
    random = Enum.random(1..num)
    IO.puts random
    if random == n do
      get_random(n, num)
    else
      random
    end
  end
end

answered Oct 6, 2017 at 7:56

denis.peplin

9,9093 gold badges50 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

elixir recursion block not returning proper value

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related