Logging the method or class name always write the Common.Logging method

Question

I'm using log4net with .NET Common.Logging. I configured a message pattern to include method and class name like so:

<layout type="log4net.Layout.PatternLayout">
  <conversionPattern value="%-5level [%M %C] - %message%newline" />
</layout>

The problem is I always get the name of the Common.Logging method and class:

FATAL [Fatal Common.Logging.Factory.AbstractLogger] - log message
INFO  [Info Common.Logging.Factory.AbstractLogger] - log message
DEBUG [Debug Common.Logging.Factory.AbstractLogger] - log message

It is most unuseful. Is there a way of printing my method name?

Community · Accepted Answer · 2017-05-23 11:47:43Z

3

I think you need to modify Common.Logging. In the file Log4NetLogger.cs replace the following line

private readonly static Type declaringType = typeof(Log4NetLogger);

with

private readonly static Type declaringType = typeof(AbstractLogger);

This should do the trick. Here is some explanation why this should work.

edited May 23, 2017 at 11:47

CommunityBot

11 silver badge

answered Jan 13, 2011 at 14:33

Stefan Egli

17.1k3 gold badges56 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

HuBeZa Over a year ago

You are right. There is an open bug associated for this task: sourceforge.net/tracker/…

Lee Chee Kiam Over a year ago

The issue was opened on 2010-08-13 but is still opened Common.Logging 2.1.1

k3b · Accepted Answer · 2011-01-13 15:22:59Z

1

This format works with my config

<layout type="log4net.Layout.PatternLayout">
  <conversionPattern value="%-5level [%logger] - %message%newline" />
</layout>

My logger is defined as

private static readonly Common.Logging.ILog logger = 
              Common.Logging.LogManager.GetCurrentClassLogger();

I use these unmodified dlls

Common.Logging.dll ver 2.0.0.0
Common.Logging.Log4Net.dll ver 2.0.0.0
log4net.dll ver 1.2.10

Update: In the logging messages i add the methodname into the logging call as text so i have no performance overhead with analysing the call stack to get the methodname.

edited Jan 13, 2011 at 15:22

answered Jan 13, 2011 at 14:46

k3b

14.8k7 gold badges56 silver badges88 bronze badges

1 Comment

HuBeZa Over a year ago

You are right. this solves the class name problem. The method name is a much bigger one, especially since I don't want to use reflection to get the method name all the time - only when I configure it so.

Collectives™ on Stack Overflow

Logging the method or class name always write the Common.Logging method

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related