read text file lines and create a dictionary using python

Question

I have a following text file format

Id,    person, age,  city
ef12,  james,  23,   berlin  
yt34,  mary,   45,   pisa  
rt23,  john,   56,   barcelona

I want to generate a dictionary of below kind. Please help me out .

{ef12: {person:'james', age:'23',city:'berlin'},   
yt34: {person:'mary', age:'45',city:'pisa'},    
rt23: {person:'john', age:'23',city:'barcelona'},  

}

I am stuck at below

`import time
import sys

def getData():
    file = open('traffic.txt', 'r')
    data = file.readlines()
    myDic = {}
    #for line in data.split('\n'):
    for line in data:
        tmp = line.strip().split()
        #myDic[tmp[0]]= list(tmp[1])
        #print(tmp[2])
        myDic[tmp[0]] = {tmp[1],tmp[2],tmp[3],tmp[4],tmp[5]}
    file.close()
    return myDic
theNewDictionary = getData()
print(theNewDictionary)
`

Tell us what happens when you try to run this. I see that you try to access tmp[4] and tmp[5] but you only expect tmp to have 4 elements. — Paul Cornelius
– Paul Cornelius, Commented Oct 28, 2017 at 2:12
sorry, you are right about it ! i didn't put all text values, my bad — codegeeka
– codegeeka, Commented Oct 28, 2017 at 4:05

sp________ · Accepted Answer · 2017-10-28 02:29:53Z

2

You have just to add the keys

def getData():
    file = open('traffic.txt', 'r')
    data = file.readlines()
    myDic = {}
    for line in data:
        tmp = [s.replace(' ', '') for s in line.strip().split(',')]
        myDic[tmp[0]] = {'person': tmp[1], 'age': tmp[2], 'city': tmp[3]}
    file.close()
    return myDic

edited Oct 28, 2017 at 2:29

answered Oct 28, 2017 at 2:18

sp________

2,64512 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

m3nda Over a year ago

Also the proper split(",") for each line. Usually file.read().splitlines() is more handy to create a list.

sp________ Over a year ago

@scharette the ouput is

{'ef12': {'person': 'james', 'age': '23', 'city': 'berlin'}, 'yt34': {'person': 'mary', 'age': '45', 'city': 'pisa'}, 'rt23': {'person': 'john', 'age': '56', 'city': 'barcelona'}}

I think it is the expected

aaron · Accepted Answer · 2017-10-30 17:30:49Z

1

Another way is to read the rows from the csv and update the dictionary with each row:

dicty = {}

for row in csv.DictReader(open('a.csv')):
    dicty.update({
        row['Id']: {
            'person': row['person'],
            'age'   : row['age'],
            'city'  : row['city']
        }
    })

print(dicty)
# {'ef12': {'person': 'james', 'age': '23', 'city': 'berlin'},
#  'yt34': {'person': 'mary',  'age': '45', 'city': 'pisa'},
#  'rt23': {'person': 'john',  'age': '56', 'city': 'barcelona'}}

dicty.get('ef12')
# {'age': '23', 'city': 'berlin', 'person': 'james'}

edited Oct 30, 2017 at 17:30

aaron

43.5k6 gold badges55 silver badges113 bronze badges

answered Oct 28, 2017 at 2:37

skrubber

1,1051 gold badge9 silver badges19 bronze badges

Comments

aaron · Accepted Answer · 2017-10-28 02:21:20Z

1

split by comma: split(',')
strip after split to remove spaces: [word.strip() for word in line.split(',')]
You only have 4 columns, so don't call tmp[4] and tmp[5] — it is IndexError if you do.
Name your keys in the dictionary: {'person': tmp[1], 'age': tmp[2], 'city': tmp[3]}

This means:

def getData():
    file = open('traffic.txt', 'r')
    data = file.readlines()
    myDic = {}
    for line in data:
        tmp = [word.strip() for word in line.split(',')]
        myDic[tmp[0]] = {'person': tmp[1], 'age': tmp[2], 'city': tmp[3]}
    file.close()
    return myDic

answered Oct 28, 2017 at 2:21

aaron

43.5k6 gold badges55 silver badges113 bronze badges

Collectives™ on Stack Overflow

read text file lines and create a dictionary using python

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related