Node JS: Code Refactor with almost similar codes in different forEach

Question

Say, I have some code which looks like follows:-

objects1.forEach(function check(o1) {
    if (o1.name === object.name) {
        object.name = object.name + objectType;
    }
});

objects2.forEach(function ifNameMatch(o2) {
    if (o2.name === object.name) {
        object.name = object.name + objectType;
    }
});

Is there any way I could replace this 2 forEach by one or write it in the more better way?

Any suggestion that you could give would be appreciated.

Are you looking for answer with ES5 or ES6?

Muhammad Faizan
– Muhammad Faizan

2017-11-01 07:47:06 +00:00
Commented Nov 1, 2017 at 7:47 — Muhammad Faizan
– Muhammad Faizan, Commented Nov 1, 2017 at 7:47

Muhammad Faizan · Accepted Answer · 2017-11-01 07:59:39Z

1

First I would create a generator for each object I have to do it, if its a repetitive process, then I would return a function that would process collections which is objects1 or objects2 in your scenario.

let nameMatchGenerator = (object, objectType)  => {
return (collections) => { 
  return collections.forEach(collection) => {
    collection.forEach(o => {
      if (o.name === object.name) {
        object.name = object.name + objectType;
      }
    })
  }
}
let nameMatch = (object, objectType);
nameMatch([objects1, objects2]) // you can use this function to repeat 
                             // the process for as many collections

answered Nov 1, 2017 at 7:59

Muhammad Faizan

1,7791 gold badge15 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Node JS: Code Refactor with almost similar codes in different forEach

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related