async/await in node js with express?

Question

Hi I'm new in node js I'm using node version 7.10 to make apis

My controller

  class SomeControllerClass {

     async someFunction(req, req){
        var afterDBAction = await DbHelper.SomeOtherFunction(req.body)
         // afterDBAction is comming out undefined
     }

 }

I'm seperating DbHelper to make Controller thin and clean and all business logic is to be written at DbHelper.

User is the schema and its saving data in db but I dont't know why I'm getting undefined in my controller

class DbHelper {
  SomeOtherFunction(userinfo){
      var user = new User(userinfo);
      bcrypt.hash(userinfo.password, saltRounds).then(function(hash, err) { 
          user.password = hash;
          return user.save().then(function() {
              if (err)
                  return err;
              return user;
          })
      });
  }   
}

Tomalak · Accepted Answer · 2017-11-03 07:55:59Z

2

You forgot to return a value from your function. await expects a promise.

SomeOtherFunction(userinfo) {
    return bcrypt.hash(userinfo.password, saltRounds).then(function(hash, err) { 
        var user = new User(userinfo);
        user.password = hash;
        return user.save();
    });
}

Since the promise can fail for some reason, you need to use try/catch in your async function somewhere.

answered Nov 3, 2017 at 7:55

Tomalak

340k68 gold badges547 silver badges635 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ashwintastic Over a year ago

now i'm getting Promise { <pending> } I think I have to resolve but don't know where??

Tomalak Over a year ago

Does user.save(); not resolve to the user object? What does it resolve to?

Vikash Dahiya · Accepted Answer · 2017-11-03 08:52:42Z

2

you can also write async function to make your code more clean

class DbHelper {
    async SomeOtherFunction(userinfo) {
        let hash = await bcrypt.hash(userinfo.password, saltRounds); 
        let user = new User(userinfo);
        user.password = hash;
        return user.save();

    }
}

answered Nov 3, 2017 at 8:52

Vikash Dahiya

5,8113 gold badges20 silver badges24 bronze badges

Collectives™ on Stack Overflow

async/await in node js with express?

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related