dynamically created id in javascript

Question

I need loop in Javascript - when You click on button it add ol tu ul and gave id with number, like this:

<ol id="single-task1"></ol>
<ol id="single-task2></ol>

And so on...

When I tried whit loop like this:

taskNumber = 0;

        for (var i; i<999; i++){
            taskNumber++;
        }

        var ol = document.createElement('ol'); //creating element ol
        taskValue = textField.value; //getting value from user
        taskList.appendChild(ol); //add ol to ul
        ol.id = 'single-task-'+taskNumber;
        ol.innerHTML = taskValue; //add value from user to new ol

All ol elements still have "single-task-0"... Probably loop is in wrong place or loop is wrong.

Do all the creation in the loop instead of after the loop is complete — zero298
– zero298, Commented Nov 7, 2017 at 18:32
You only incrementing taskNumber within the loop. Then, you are only working on one ol-element. Try using a debugger within your browser to see what your code is doing. — k0pernikus
– k0pernikus, Commented Nov 7, 2017 at 18:32
Why are you putting <ol> elements inside a <ul>? Did you mean <li>? Do you really need one thousand IDs? Why not simply taskList.children[taskNumber]? — Sebastian Simon
– Sebastian Simon, Commented Nov 7, 2017 at 18:35

jmargolisvt · Accepted Answer · 2017-11-07 18:33:22Z

1

You are confusing your taskNumber and your i variable. Initialize i = 0 in your loop and use that. Do all of your work within the loop. You don't need taskNumber.

answered Nov 7, 2017 at 18:33

jmargolisvt

6,1165 gold badges32 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

dynamically created id in javascript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related