Adding TabItems dynamically

Question

I have a TabControl control

<TabControl Name="Farms_myVillages"
            ItemsSource="{Binding Villages}">
</TabControl/>

In the code behind I add some tabs dynamically to the TabControl as follows:

foreach (Village vill in Villages)
{
    TabItem tab = new TabItem();
    tab.Header = vill.Name;
    VillageUserControl c = new VillageUserControl();
    c.DataContext = vill;
    tab.Content = c;
    Farms_myVillages.Items.Add(tab);
}

where VillageUserControl is a UserControl that deal with the specified village. This code works fine and it gets the expected results...

The problem is that I don't want this to be in the code behind but just in the xaml itself.

I try this:

<TabControl Name="Farms_myVillages"
            ItemsSource="{Binding Villages}">
      <TabControl.ItemContainerStyle>
          <Style TargetType="TabItem">
              <Setter Property="Header" Value="{Binding Name}"/>
              <Setter Property="Content">
                 <Setter.Value>
                    <u:VillageUserControl DataContext="{Binding}"/>
                 </Setter.Value>
              </Setter>
          </Style>
      </TabControl.ItemContainerStyle>
</TabControl>

After I run it, it throws an exception: "Specified element is already the logical child of another element. Disconnect it first."

Did I miss something? Please help me here...

Bakudan · Accepted Answer · 2016-02-21 16:08:14Z

13

You set the wrong thing, you should not modify the ItemContainerStyle but the TabControl.ItemTemplate for the header and TabControl.ContentTemplate for the content.

(The exception may have to do with the fact that in the style only one VillageUserControl is created, but the style applies to multiple tab items.)

edited Feb 21, 2016 at 16:08

Bakudan

19.5k9 gold badges56 silver badges76 bronze badges

answered Jan 18, 2011 at 5:09

brunnerh

188k30 gold badges362 silver badges434 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

brunnerh Over a year ago

You're welcome, glad it helped :) (On a side note: You can mark answers via the checkmark outline that appears if you move your mouse below the votes on the left, so far you have not accepted any answers to your questions, you might want to go through them and accept the answer that helped the most)

ΩmegaMan · Accepted Answer · 2017-09-06 15:10:05Z

3

Now it is working:

<TabControl Name="Farms_myVillages" 
           ItemsSource="{Binding Villages}">
       <TabControl.ItemTemplate>
            <DataTemplate>
                 <TextBlock Text="{Binding Name}"/>
            </DataTemplate>
       </TabControl.ItemTemplate>
      <TabControl.ContentTemplate>
            <DataTemplate>
                <u:VillageResources/>
            </DataTemplate>
      </TabControl.ContentTemplate>
</TabControl>

edited Sep 6, 2017 at 15:10

ΩmegaMan

32.2k13 gold badges110 silver badges138 bronze badges

answered Jan 18, 2011 at 13:41

Sami Abdelgadir Mohammed

2631 gold badge6 silver badges15 bronze badges

Comments

akjoshi · Accepted Answer · 2015-02-11 11:11:00Z

2

Your approach of not having this in code behind is right, instead of using ItemContainerStyle use ItemTemplate and ContentTemplate. You can have a look at this sample from Josh Smith for creating a tabs using Templates and Styles -

http://code.msdn.microsoft.com/mag200902MVVM/Release/ProjectReleases.aspx?ReleaseId=2026

edited Feb 11, 2015 at 11:11

answered Jan 18, 2011 at 8:46

akjoshi

15.8k13 gold badges108 silver badges122 bronze badges

Collectives™ on Stack Overflow

Adding TabItems dynamically

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related