JS - Object Constructor Methods

Question

I am trying to make an object that includes the teams points (as shown below where it says "this.update"). When I run the program it does not seem to give the points to the teams and it does not seem to even evaluate both teams' goals.

I want the team1Points and team2Points properties to be derived from an IF statement like the one above or another solution would help, akin to the 1 point to both teams for a draw, 3 points for a win, 0 for a loss.

teamsArray = ["Blue Team", "Red Team"];

function match(team1Name, team2Name, team1Goals, team2Goals) {
  this.team1Name = team1Name;
  this.team1Goals = team1Goals;
  this.team2Name = team2Name;
  this.team2Goals = team2Goals;
  this.update = function() {
    if (team1Goals > team2Goals) {
      team1Points = 3;
      team2Points = 0;
    } else if (team2Goals > team1Goals) {
      team2Points = 3;
      team1Points = 0;
    } else if (team1Goals == team2Goals) {
      team1Points = 1;
      team2Points = 1;
    }
  };
  this.update();
}

testMatch();

function testMatch() {
  var match1 = new match(teamsArray[0], teamsArray[1], 2, 0);
  console.log(match1);
}

Try this.team1Points = 0 etc.

Mark
– Mark

2017-11-16 00:57:09 +00:00
Commented Nov 16, 2017 at 0:57 — Mark
– Mark, Commented Nov 16, 2017 at 0:57

Domino · Accepted Answer · 2017-11-16 16:59:38Z

1

Your method creates global variables instead of properties, and you never even called it!

In order to avoid issues like this, I suggest switching to the modern JavaScript syntax. Begin your scripts with the instruction 'use strict'; to enable strict mode and define variables using let instead of var. If you do that, the browser won't let you define global variables from within a function.

As for the solution to your code:

function match(team1Name, team2Name, team1Goals, team2Goals) {
  this.team1Name = team1Name;
  this.team1Goals = team1Goals;
  this.team2Name = team2Name;
  this.team2Goals = team2Goals;
  this.team1Points = this.team2Points = 0;

  this.update = function() {
    if (this.team1Goals > this.team2Goals) {
      this.team1Points = 3;
      this.team2Points = 0;
    } else if (this.team2Goals > this.team1Goals) {
      this.team2Points = 3;
      this.team1Points = 0;
    } else if (this.team1Goals == this.team2Goals) {
      this.team1Points = 1;
      this.team2Points = 1;
    }
  };
}

And don't forget to call .update() somewhere.

m = new match("Alpha", "Beta", 0, 2);
m.update();

console.log("Team " + m.team1Name + " has " + m.team1Points + " points.");
console.log("Team " + m.team2Name + " has " + m.team2Points + " points.");

edited Nov 16, 2017 at 16:59

answered Nov 16, 2017 at 0:56

Domino

6,8781 gold badge37 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Domino Over a year ago

Wow, sorry if you noticed that horrible sequence of edits. I'm a bit rusty on SO usage.

Jay Over a year ago

I forgot to add in the team1Points and team2Points variables but it doesnt really answer my question. I tried to do console.log(testMatch.update()) and it doesnt really solve the question. I am trying to get team1Points to = 3 as they have scored more goals. Maybe I am calling the update() function wrong im unsure

Domino Over a year ago

The update function doesn't return anything, so logging its result won't do. You'll want to log the variables themselves if you want to check their values.

Domino Over a year ago

@Jay I edited the answer with an example of how you'd create a match and log the results.

Domino Over a year ago

Ah, gotcha. I forgot to add this. in the conditions as well.

|

alen · Accepted Answer · 2017-11-16 00:58:16Z

1

teamsArray = ["Blue Team", "Red Team"];

function match(team1Name, team2Name, team1Goals, team2Goals) {
  this.team1Name = team1Name;
  this.team1Goals = team1Goals;
  this.team2Name = team2Name;
  this.team2Goals = team2Goals;
  this.update = function() {
    if (team1Goals > team2Goals) {
      this.team1Points = 3;
      this.team2Points = 0;
    } else if (team2Goals > team1Goals) {
      this.team2Points = 3;
      this.team1Points = 0;
    } else if (team1Goals == team2Goals) {
      this.team1Points = 1;
      this.team2Points = 1;
    }
  };
  this.update();
}

testMatch();

function testMatch() {
  var match1 = new match(teamsArray[0], teamsArray[1], 2, 0);
  console.log(match1);
}

answered Nov 16, 2017 at 0:58

alen

2762 silver badges10 bronze badges

Comments

heluwe · Accepted Answer · 2017-11-16 01:00:01Z

teamsArray = ["Blue Team", "Red Team"];

function match(team1Name, team2Name, team1Goals, team2Goals) {
  this.team1Name = team1Name;
  this.team1Goals = team1Goals;
  this.team2Name = team2Name;
  this.team2Goals = team2Goals;
  this.update = function() {
    if (team1Goals > team2Goals) {
      team1Points = 3;
      team2Points = 0;
      return "team1 win"
    } else if (team2Goals > team1Goals) {
      team2Points = 3;
      team1Points = 0;
      return "team2 win"
    } else if (team1Goals == team2Goals) {
      team1Points = 1;
      team2Points = 1;
      return "draw"
    }
  };
}

testMatch();

function testMatch() {
  var match1 = new match(teamsArray[0], teamsArray[1], 2, 0);

  console.log(match1.update());
}

Collectives™ on Stack Overflow

JS - Object Constructor Methods

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related