using a generic method when using interface

Question

Im stuck on a generics issue. I have a method that returns DbSet from a DbContext object based on the object type.

Now I want to write I method where I pass in a object that implements a interface called IBaseData (that all entities implements). I want to use the existing method to return the correct DbSet based on the type of the IBaseData object, but I can't get it to work.

I've tried various versions of , typeof and gettype.

Existing method:

public GenericRepository<T> GetRepo<T>() where T : class
{
    return new GenericRepository<T>(_context);
}

New method (this is just what Im trying to do):

public async Task SetDateLastInvoked<T>(IBaseData data, int id)
{
    var tmp = GetRepo<typeof(data)>().Where(obj => obj.Id.Equals(id));
    tmp.DateLastInvoked = DateTime.Now;

    await SaveChangesAsync();
}

If you are using EF the problem you will run into is that EF does not support querying on interface properties, at least it didn't last I checked. This applies even if you are in a generic method — Titian Cernicova-Dragomir
– Titian Cernicova-Dragomir, Commented Dec 6, 2017 at 20:03
Ah okei. But what if all the entities derive from a class that implements the interface. So I don't pass in the interface but the object that implements it, if you understand what I mean ? — SteinTech
– SteinTech, Commented Dec 6, 2017 at 20:05
If you constraint the generic type on base type and not the interface I believe it will work, but I have not tested — Titian Cernicova-Dragomir
– Titian Cernicova-Dragomir, Commented Dec 6, 2017 at 20:07
If, the type of data is not known at compile time, to invoke the generic method you will need reflection as described here stackoverflow.com/questions/232535/… — Titian Cernicova-Dragomir
– Titian Cernicova-Dragomir, Commented Dec 6, 2017 at 20:12
What's the origin of the data object when it enters SetDateLastInvoked? More specifically, is it attached to a context ar that point? — Gert Arnold
– Gert Arnold, Commented Dec 6, 2017 at 20:16

Erik Philips · Accepted Answer · 2017-12-06 20:06:58Z

1

I assume you are doing something like:

public interface IBaseData 
{
  int Id { get; set; }
}

Then a method would looe like

public GenericRepository<T> GetRepo<T>() 
  where T : class
{
  return new GenericRepository<T>(_context);
}

public async Task SetDateLastInvoked<T>(int id)
  where T : class, IBaseData
{
  var tmp = GetRepo<T>().FirstOrDefault(obj => obj.Id == id));
  tmp.DateLastInvoked = DateTime.Now;

  await SaveChangesAsync();
}

Usage:

public MyClass : IBaseData 
{ 
  public Id { get; set }
}

SetDateLastInvoked<MyClass>(1);

answered Dec 6, 2017 at 20:06

Erik Philips

54.9k11 gold badges133 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Evk Over a year ago

@TheRuler won't hurt to also restrict your GetRepo<T> to where T: IBaseData - will prevent passing some type completely unrelated to your entities (which will fail at runtime).

SteinTech Over a year ago

I think I've done that now.. not exactly what you said, but where T : class, IBaseData

SteinTech · Accepted Answer · 2017-12-06 21:47:09Z

0

Ended up with this, based on previous answer:

public async Task SetLastInvoked<T>(int id) where T : class, IBaseData
{
    var tmp = await GetRepo<T>().Single(obj => obj.Id.Equals(id));
    tmp.DateLastInvoked = DateTime.Now;

    await SaveChangesAsync();
}

I also created another method based on the same pattern:

public async Task DeleteItem<T>(int id, bool removeRow) where T : class, IBaseData
{
    if (removeRow)
    {
        GetRepo<T>().Delete(await GetRepo<T>().Single(obj => obj.Id.Equals(id)));
    }
    else
    {
        var tmp = await GetRepo<T>().Single(obj => obj.Id.Equals(id));
        tmp.Active = false;
    }

    await SaveChangesAsync();
}

edited Dec 6, 2017 at 21:47

answered Dec 6, 2017 at 20:32

SteinTech

4,1444 gold badges44 silver badges91 bronze badges

Collectives™ on Stack Overflow

using a generic method when using interface

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related