Adding json data to a listview

Question

I am trying to add data to my listview using json data returned by an api, I have a class with the structure of the list, however when i try and add the data in using a for loop its fails and doesn't add it in, it tries to run the loop once then exits the loop. On expecting the list it has a count of 0.

ListAvivity.cs

dynamic mFarms = JsonConvert.DeserializeObject(content);

List<MyList.Data> mItems = new List<FarmsList.Data>();

foreach(var items in mFarms.data)
{
  mItems.Add(new MyList.Data() {FarmID = items["FarmID"].ToString(), FarmerSurname = items["FarmerSurname"].ToString(), 
                FarmerForename = items["FarmerForename"].ToString(), FarmName = items["FarmName"].ToString()});
}

MyList.cs

public class MyList
{
    public class Data
    {
        public int FarmID { get; set; }
        public string FarmName { get; set; }
        public string FarmerSurname { get; set; }
        public string FarmerForename { get; set; }
    }

    public class RootObject
    {
        public int code { get; set; }
        public string status { get; set; }
        public string message { get; set; }
        public Data data { get; set; }
    }

}

Json Data

{
"code": 201,
"status": "Success",
"message": "Object found",
"data": [
    {
        "FarmID": 1,
        "FarmName": "Test1",
        "FarmerSurname": "Test",
        "FarmerForename": "Test"
    },
    {
        "FarmID": 2,
        "FarmName": "Test2",
        "FarmerSurname": "Test",
        "FarmerForename": "Test"
    }
  ]
 }

its fails and doesn't add it in. - So what does happen? Do you get an error? What is it? — Equalsk
– Equalsk, Commented Dec 15, 2017 at 17:08
The example you've shown works fine for me, it loops twice as expected and reads the data correctly. — Equalsk
– Equalsk, Commented Dec 15, 2017 at 17:16

Emre Kabaoglu · Accepted Answer · 2017-12-15 17:34:49Z

1

The program didn't enter the loop because you couldn't deserialize the json object. I suggest you to deserialize it as a known type instead of dynamic.

Create json classes;

public class Datum
{
    public int FarmID { get; set; }
    public string FarmName { get; set; }
    public string FarmerSurname { get; set; }
    public string FarmerForename { get; set; }
}

public class Content
{
    public int code { get; set; }
    public string status { get; set; }
    public string message { get; set; }
    public List<Datum> data { get; set; }
}

Then deserialize it;

var mFarms = JsonConvert.DeserializeObject<Content>(content);
List<MyList.Data> mItems = new List<FarmsList.Data>();

foreach(var items in mFarms.data)
{
  mItems.Add(new MyList.Data() {FarmID = items["FarmID"].ToString(), FarmerSurname = items["FarmerSurname"].ToString(), 
                FarmerForename = items["FarmerForename"].ToString(), FarmName = items["FarmName"].ToString()});
}

Also, to print mItems, build a loop;

foreach (var mitem in mItems)
{
    Console.WriteLine(mitem.FarmID);
    Console.WriteLine(mitem.FarmerSurname);
    //etc
}

edited Dec 15, 2017 at 17:34

answered Dec 15, 2017 at 17:18

Emre Kabaoglu

13.2k4 gold badges27 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Equalsk Over a year ago

The provided JSON absolutely deserializes into a dynamic type and the loop works fine.

Emre Kabaoglu Over a year ago

Yes, I tried it there is no problem with dynamic. But as I said it could be better to use a known type.

Equalsk Over a year ago

Yes, that is ideal, but it doesn't answer the question as the issue wasn't to do with whether OP deserialized into dynamic or a class anyway.

Gurpreet Bhopal Over a year ago

the app crashes when it tries to add the item into the list

Emre Kabaoglu Over a year ago

What is the error ? Would you provide it in detail ?

|

Collectives™ on Stack Overflow

Adding json data to a listview

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related