Jquery each on DOM element - Push in array error

Question

I try to use each() function on my DOM to get field dynamically added. But I hava a probleme with this code :

  var nouvelle_entree=new Object();
    $('div[name="declaration-ligne-entree"]').each(function () {
    nouvelle_entree.name=$(this).children('input[name="system-input-name"]').val();
    nouvelle_entree.values=$(this).children('input[name="system-input-valeur"]').val().split(",");
    console.log(nouvelle_entree);
    mockSystem.input.push(nouvelle_entree);
    });
    console.log(mockSystem.input);

The push function always push the last child and not the other but on my console log in have the good values.

log 1 : {name: "a", values: Array(1)}

log 2 : {name: "b", values: Array(1)}

log 3: [

{name: "b", values: Array(1)}

{name: "b", values: Array(1)}

]

Why ?

Short answer is you are pushing the exact same object into array each time, and overwriting it's values every iteration of the loop — charlietfl
– charlietfl, Commented Dec 16, 2017 at 16:39

halfer · Accepted Answer · 2017-12-17 01:43:03Z

3

Why ?

Since in every iteration you're overwriting the same object nouvelle_entree.

You need to define the object nouvelle_entree in every iteration not just the first time, else the variable will always contains the informations of the last iteration, e.g :

$('div[name="declaration-ligne-entree"]').each(function() {
  var nouvelle_entree = {};

  nouvelle_entree.name = $(this).children('input[name="system-input-name"]').val();
  nouvelle_entree.values = $(this).children('input[name="system-input-valeur"]').val().split(",");

  mockSystem.input.push(nouvelle_entree);
});

console.log(mockSystem.input);

edited Dec 17, 2017 at 1:43

halfer

20.2k20 gold badges111 silver badges208 bronze badges

answered Dec 16, 2017 at 16:37

Zakaria Acharki

67.5k15 gold badges79 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Jquery each on DOM element - Push in array error

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related