Passing variables between controllers and returning (PHP)

Question

Probably is a very easy question, but I'm new and after trying to find a similar I'm still unsure:

So I have an AJAX form pointing to:

function postLogin(Request $request){
   $this->fatherAuth($request); 

   return response() -> json(['url' => '/login-ok',], 200); 
}

Then I have:

public function fatherAuth($request){

    $validator = Validator::make($request->all(), [
        'email' => 'required|email',
    ],[
         'email.required' => 'Email needed',
    ]);

    # do some other checks and if there's some auth error:# 
    return response() -> json(['url' => '/login-bad',], 400); 
}

So what's happening is that I'm always getting the 200 response instead of the 400.

Should I pass a variable to postLogin? Should I send it to a new function?

BTW the reason of creating fatherAuth is because this code is shared between several controllers.

What would be the best solution / best practice?

Thanks

Marcin Nabiałek · Accepted Answer · 2017-12-25 19:03:29Z

2

You are getting 200 response because you are not doing anything with response returned by fatherAuth method.

To make it work you should use something like:

function postLogin(Request $request){
   $response = $this->fatherAuth($request); 

   if ($response instanceof \Illuminate\Http\Response) {
       return $response;
   }

   return response() -> json(['url' => '/login-ok',], 200); 
}

but as you see it wouldn't be the best approach.

That's why you should use middleware for this. For example:

<?php

namespace App\Http\Middleware;

use Closure;

class CheckAuth
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        // here you do anything you want and assign to $result variable
        if (!$result) {
            return response() -> json(['url' => '/login-bad',], 400); 
        }

        return $next($request);
    }
}

and then you can apply this middleware to all the routes adding to $middleware array in App/Http/Kernel.php file:

App\Http\Middleware\CheckAuth::class,

Of course you can apply this middleware only to selected routes if you need.

After that in your postLogin method it's enough to have only:

function postLogin(Request $request){
   return response() -> json(['url' => '/login-ok',], 200); 
}

answered Dec 25, 2017 at 19:03

Marcin Nabiałek

112k43 gold badges272 silver badges300 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

TrOnNe Over a year ago

oh, thank you very much! So I went option 1 because it was much more easy haha I just changed ...instanceof.. to if ($response) {return $response;}else {200}

Collectives™ on Stack Overflow

Passing variables between controllers and returning (PHP)

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related